Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add mailmap entry for KhafraDev #47512

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 11, 2023

This will make git log entries for KhafraDev show up using the name in the README, which is required so that find-inactive-collaborators.mjs doesn't incorrectly flag him for removal.

This will make `git log` entries for KhafraDev show up using the name
in the README, which is required so that find-inactive-collaborators.mjs
doesn't incorrectly flag him for removal.
@Trott Trott requested a review from KhafraDev April 11, 2023 15:10
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 11, 2023
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 11, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit b318f84 into nodejs:main Apr 11, 2023
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b318f84

@Trott Trott deleted the mailmap branch April 11, 2023 19:24
targos pushed a commit that referenced this pull request May 2, 2023
This will make `git log` entries for KhafraDev show up using the name
in the README, which is required so that find-inactive-collaborators.mjs
doesn't incorrectly flag him for removal.

PR-URL: #47512
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
This will make `git log` entries for KhafraDev show up using the name
in the README, which is required so that find-inactive-collaborators.mjs
doesn't incorrectly flag him for removal.

PR-URL: #47512
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
This will make `git log` entries for KhafraDev show up using the name
in the README, which is required so that find-inactive-collaborators.mjs
doesn't incorrectly flag him for removal.

PR-URL: nodejs#47512
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants