Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use webidl DOMString converter in EventTarget #47514

Merged
merged 4 commits into from
Apr 14, 2023
Merged

lib: use webidl DOMString converter in EventTarget #47514

merged 4 commits into from
Apr 14, 2023

Conversation

KhafraDev
Copy link
Member

This implements a webidl converter for converting a value to a webidl DOMString and uses it in EventTarget.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 11, 2023
anonrig
anonrig reviewed Apr 11, 2023
View reviewed changes
lib/internal/webidl.js Outdated Show resolved Hide resolved
lib/internal/webidl.js Show resolved Hide resolved
@anonrig anonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51144/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51162/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51170/

@github-actions github-actions bot mentioned this pull request Apr 13, 2023
Open
36 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51201/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit 41b8872 into nodejs:main Apr 14, 2023
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 41b8872

@KhafraDev KhafraDev deleted the domstring-webidl branch April 14, 2023 14:18
targos pushed a commit that referenced this pull request May 2, 2023
@KhafraDev @targos
lib: use webidl DOMString converter in EventTarget
e8bc03b 
PR-URL: #47514
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@KhafraDev @danielleadams
lib: use webidl DOMString converter in EventTarget
f403c2d 
PR-URL: #47514
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@KhafraDev @MoLow
lib: use webidl DOMString converter in EventTarget
fa447b5 
PR-URL: nodejs#47514
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KhafraDev @nodejs-github-bot @benjamingr @anonrig @aduh95