doc: fix release-post script location #47517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
richardlau
approved these changes
Apr 11, 2023
aymen94
approved these changes
Apr 12, 2023
targos
reviewed
Apr 12, 2023
danielleadams
approved these changes
Apr 12, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
force-pushed
the
fix-release-blog-script-location
branch
from
7b32e0e
to
99b767d
Compare
BethGriggs
approved these changes
Apr 12, 2023
ruyadorno
approved these changes
Apr 12, 2023
lpinca
approved these changes
Apr 12, 2023
lpinca
reviewed
Apr 12, 2023
| @@ -954,7 +954,12 @@ There is an automatic build that is kicked off when you promote new builds, so | |||
| within a few minutes nodejs.org will be listing your new version as the latest | |||
| release. However, the blog post is not yet fully automatic. | |||
|
|
|||
| Create a new blog post by running the [nodejs.org release-post.js script][]. | |||
| Create a new blog post by running the [nodejs.org release-post.js script][]: | |||
There was a problem hiding this comment.
I think the link name (release-post.js script) should also be changed.
HarshithaKP
approved these changes
Apr 13, 2023
tniessen
approved these changes
Apr 17, 2023
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 17c9aa2 |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #47517 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #47517 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#47517 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release-post script now is in a different location and should be called directly with
nodecc: @nodejs/releasers