Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: initialize import.meta on eval #47551

Merged
merged 1 commit into from
Apr 19, 2023
Merged

esm: initialize import.meta on eval #47551

merged 1 commit into from
Apr 19, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 13, 2023

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Apr 13, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51269/

@github-actions github-actions bot mentioned this pull request Apr 15, 2023
Open
33 tasks
@JakobJingleheimer JakobJingleheimer added this to In progress in Loaders via automation Apr 15, 2023
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
Open
35 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51339/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51347/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51349/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51355/

@GeoffreyBooth GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Apr 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit ee08c70 into nodejs:main Apr 19, 2023
40 checks passed
Loaders automation moved this from In progress to Done Apr 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in ee08c70

@aduh95 aduh95 deleted the import-meta-eval branch April 19, 2023 20:55
targos pushed a commit that referenced this pull request May 2, 2023
@aduh95 @targos
esm: initialize import.meta on eval
c150976 
PR-URL: #47551
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targos targos mentioned this pull request May 2, 2023
Merged
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 3, 2023
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
esm: initialize import.meta on eval
40fa6e4 
PR-URL: nodejs#47551
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
esm: initialize import.meta on eval
5de37a1 
PR-URL: #47551
Backport-PR-URL: #50669
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: initialize import.meta on eval
562a477 
PR-URL: nodejs/node#47551
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: initialize import.meta on eval
740eae8 
PR-URL: nodejs/node#47551
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@guybedford guybedford guybedford approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
Loaders
Done
Milestone
ESM Loaders: Stable (CJS parity)
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aduh95 @nodejs-github-bot @GeoffreyBooth @guybedford @JakobJingleheimer @targos @danielleadams