Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove markdown link from heading #47585

Conversation

tniessen
Copy link
Member

This is the only instance of such a link and it is rendered incorrectly in the TOC.

screenshot showing the incorrectly rendered TOC

This is the only instance of such a link and it is rendered
incorrectly in the TOC.
@tniessen tniessen added doc Issues and PRs related to the documentations. policy Issues and PRs related to the policy subsystem. labels Apr 16, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 16, 2023

Review requested:

  • @nodejs/security-wg

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2023
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9b6f7f0 into nodejs:main Apr 18, 2023
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9b6f7f0

targos pushed a commit that referenced this pull request May 2, 2023
This is the only instance of such a link and it is rendered
incorrectly in the TOC.

PR-URL: #47585
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
This is the only instance of such a link and it is rendered
incorrectly in the TOC.

PR-URL: #47585
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
This is the only instance of such a link and it is rendered
incorrectly in the TOC.

PR-URL: nodejs#47585
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. policy Issues and PRs related to the policy subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants