fs: make recursive readdir algorithms iterative #47650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Ethan-Arrowood
force-pushed
the
improve-recursive-algs
branch
from
7de1599
to
28fc566
Compare
Ethan-Arrowood
changed the title
anonrig
reviewed
Apr 20, 2023
anonrig
approved these changes
Apr 20, 2023
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
anonrig
added
the
commit-queue-squash
mscdex
reviewed
Apr 21, 2023
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
aduh95
reviewed
Apr 22, 2023
39 tasks
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
reviewed
Apr 24, 2023
mscdex
reviewed
Apr 24, 2023
mscdex
reviewed
Apr 24, 2023
38 tasks
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Thank you for the great recommendations @mscdex I have made all the changes and thought I haven't timed it, the tests are running noticeably faster on my local machine 😄 |
36 tasks
|
Is there anything blocking this from merging? |
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
May 9, 2023
|
Since 7 days have passed since you opened this PR, we can merge this with only 1 review, but I prefer to wait a couple of days to receive a review from @nodejs/fs team. |
I will take a look later |
jasnell
approved these changes
May 10, 2023
MoLow
approved these changes
May 10, 2023
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 12a93ce |
This was referenced May 11, 2023
targos
pushed a commit
that referenced
this pull request
May 12, 2023
PR-URL: #47650 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This was referenced May 13, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47650 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47650 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the new
readdirrecursive algorithm to be iterative. This helps avoid potential callstack issues for very large directories.