Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update ada to 2.2.0 #47678

Merged
merged 2 commits into from Apr 25, 2023
Merged

deps: update ada to 2.2.0 #47678

merged 2 commits into from Apr 25, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of ada to 2.2.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Apr 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 23, 2023
@anonrig
Copy link
Member

anonrig commented Apr 23, 2023 •
edited

We have couple of breaking changes. I'll update this pull request.

@anonrig anonrig self-assigned this Apr 23, 2023
@anonrig anonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51440/

@anonrig
Copy link
Member

anonrig commented Apr 23, 2023

@nodejs/url please review

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51441/

@github-actions github-actions bot mentioned this pull request Apr 24, 2023
Open
39 tasks
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2023
benjamingr
benjamingr approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2023
@github-actions github-actions bot mentioned this pull request Apr 25, 2023
Open
38 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit 25b6ddf into main Apr 25, 2023
61 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 25b6ddf

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-ada branch April 25, 2023 00:47
This was referenced Apr 26, 2023
Open
Open
Open
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@nodejs-github-bot @yjl9903
deps: update ada to 2.2.0
1e728e5 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@nodejs-github-bot @yjl9903
deps: update ada to 2.2.0
2e6cb2f 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
Open
32 tasks
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
@nodejs-github-bot @yjl9903
deps: update ada to 2.2.0
2658b6a 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
@nodejs-github-bot @targos
deps: update ada to 2.2.0
f3ee312 
PR-URL: #47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
@anonrig anonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
fbc5031 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
5fc41f5 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
ea60a85 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@anonrig anonrig added the backport-open-v18.x Indicate that the PR has an open backport. label Jun 5, 2023
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 17, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
b0099ff 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 23, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
dcd03d0 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
89125aa 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
82df2b9 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
c884b15 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
368aae9 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 6, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
4c629b1 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
ab6b31e 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.2.0
40d27a7 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.2.0
42e690f 
PR-URL: #47678
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 12, 2023
Merged
@danielleadams danielleadams added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees

@anonrig anonrig

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nodejs-github-bot @anonrig @benjamingr @aymen94 @danielleadams