deps: update histogram to 0.11.8 #47742

marco-ippolito · 2023-04-27T09:57:24Z

updated to new release https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.11.7 that contains version header

tniessen

The overall structure is now different since it's mirroring the upstream repository. Previously, we just pulled in what we needed. We probably should not be pulling in files that are not referenced from the .gyp file.

That being said, a simple shell script will have trouble determining what files are needed and which are not. This is strictly more difficult than just updating the gyp file as I did for googletest, and making a mistake requires more manual work than just updating the gyp file.

The version header file was never needed, but a strategy for determining what files to pull in is.

deps/histogram/README.md

marco-ippolito · 2023-04-27T10:23:49Z

I guess the header file is good because it will help checking version diff. updating the gyp files is not something that can be automated easily and it will probably break anyways

deps/histogram/histogram.gyp

nodejs-github-bot · 2023-04-28T10:04:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51531/

nodejs-github-bot · 2023-04-28T13:41:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51534/

nodejs-github-bot · 2023-05-01T07:20:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51557/

RafaelGSS · 2023-05-03T18:25:42Z

I agree with @tniessen. While we don't do it in other dependencies such as OpenSSL (AFAIK), would be great to include just the files needed in Node.js. However, I think it can be slightly complex to maintain if they change the structure often.

UlisesGascon

After a discussion with @marco-ippolito in nodejs/security-wg#977. Video Record (min: 14:21). Seems quite complex to only include the files that are used by Node.js as the dependency file estructure can change over the time. Adding useless files can make the project overall heavier and slower when we clone/download Node, but the files itself are full ignored after that, so there is no impact in the perf/build/etc..

marco-ippolito · 2023-05-22T12:27:21Z

I've removed all the unnecessary files

nodejs-github-bot · 2023-05-22T12:38:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51908/

tniessen · 2023-05-22T15:04:56Z

deps/histogram/include/hdr/hdr_histogram_version.h

This file isn't really needed, but I guess it also does no harm.

deps/histogram/include/hdr/hdr_histogram_version.h

nodejs-github-bot · 2023-05-25T07:44:59Z

Landed in d2a1f71...442c352

PR-URL: #47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: nodejs#47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

upstream dep histogram 0.11.7 moved its include path from src/ to include/ Xref: nodejs/node#47742

* chore: bump node in DEPS to v18.17.0 * chore: update build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch Xref: nodejs/node#46930 manually sync patch to minor upstream code shear * chore: update build_ensure_native_module_compilation_fails_if_not_using_a_new.patch Xref: nodejs/node#48248 manually sync patch to minor upstream code shear * chore: update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#47824 chore: upstream func throwIfUnsupportedURLProtocol() has been removed, so no need to patch it * chore: update api_pass_oomdetails_to_oomerrorcallback.patch Xref: nodejs/node#47695 manually sync patch to minor upstream code shear * chore: remove fix_prevent_changing_functiontemplateinfo_after_publish.patch Xref: nodejs/node#46979 (upstreamed patch) Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2718147 (related) * chore: update fix_adapt_debugger_tests_for_upstream_v8_changes.patch Xref: nodejs/node#47274 manually sync patch to minor upstream code shear some tests moved from sequential to parallel * chore: remove fix_libc_buffer_overflow_in_string_view_ctor.patch Xref: fix_libc_buffer_overflow_in_string_view_ctor.patch patch is no longer needed due to upstream bump to ada 2.2.0 * chore: remove fix_preventing_potential_oob_in_ada_no_scheme_parsing.patch Xref: nodejs/node#47339 patch is no longer needed due to upstream bump to ada 2.2.0 * chore: rebuild filenames.json several files removed/added/changed upstream * chore: update build_add_gn_build_files.patch upstream dep histogram 0.11.7 moved its include path from src/ to include/ Xref: nodejs/node#47742 * chore: update fix_crypto_tests_to_run_with_bssl.patch Xref: nodejs/node#47160 BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of BIO_s_mem()), so use BIO_s_mem() instead. Related discussion of secure heap support in BoringSSL: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: ftbfs in node dep ada * fix: ftbfs in node dep uvwasi * chore: rebuild patches * chore: update fix_handle_boringssl_and_openssl_incompatibilities.patch Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`. BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead. Upstream Node.js change that prompted this: nodejs/node#47160 Related discussion of BoringSSL support of secure heap: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: work around Node 18 isURL() regression * chore: sort script/node-disabled-tests.json alphabetically * test: add parallel/test-snapshot-argv1 to disabled list test: add parallel/test-snapshot-namespaced-builtin to disabled list We don't support that type of snapshotting at the moment. * chore: disable flaky node test parallel/test-dgram-send-cb-quelches-error fails upstream in v18.x on my box as well * ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set * fixup! fix: work around Node 18 isURL() regression fix: infinite loop regression * fixup! fix: work around Node 18 isURL() regression * chore: patch fixtures/errors/force_colors.snapshot The line numbers in the stacktrace from our v8 build don't match what Node's tests are expecting, so update the stacktrace to match our build. The specific numbers probably aren't t needed for the force_colors test, which is trying to see whether or not the lines are greyed out. One option is to upstream a test change to stop hardcoding the stacktrace. * fixup! fix: work around Node 18 isURL() regression fix; pull in upstream bugfix * fixup! ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set chore: do not inject ELECTRON_RUN_AS_NODE in test-assert-colors.js * chore: disable flaky node test parallel/test-debugger-random-port-with-inspect-port --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>

PR-URL: nodejs#47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

* chore: bump node in DEPS to v18.17.0 * chore: update build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch Xref: nodejs/node#46930 manually sync patch to minor upstream code shear * chore: update build_ensure_native_module_compilation_fails_if_not_using_a_new.patch Xref: nodejs/node#48248 manually sync patch to minor upstream code shear * chore: update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#47824 chore: upstream func throwIfUnsupportedURLProtocol() has been removed, so no need to patch it * chore: update api_pass_oomdetails_to_oomerrorcallback.patch Xref: nodejs/node#47695 manually sync patch to minor upstream code shear * chore: remove fix_prevent_changing_functiontemplateinfo_after_publish.patch Xref: nodejs/node#46979 (upstreamed patch) Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2718147 (related) * chore: update fix_adapt_debugger_tests_for_upstream_v8_changes.patch Xref: nodejs/node#47274 manually sync patch to minor upstream code shear some tests moved from sequential to parallel * chore: remove fix_libc_buffer_overflow_in_string_view_ctor.patch Xref: fix_libc_buffer_overflow_in_string_view_ctor.patch patch is no longer needed due to upstream bump to ada 2.2.0 * chore: remove fix_preventing_potential_oob_in_ada_no_scheme_parsing.patch Xref: nodejs/node#47339 patch is no longer needed due to upstream bump to ada 2.2.0 * chore: rebuild filenames.json several files removed/added/changed upstream * chore: update build_add_gn_build_files.patch upstream dep histogram 0.11.7 moved its include path from src/ to include/ Xref: nodejs/node#47742 * chore: update fix_crypto_tests_to_run_with_bssl.patch Xref: nodejs/node#47160 BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of BIO_s_mem()), so use BIO_s_mem() instead. Related discussion of secure heap support in BoringSSL: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: ftbfs in node dep ada * fix: ftbfs in node dep uvwasi * chore: rebuild patches * chore: update fix_handle_boringssl_and_openssl_incompatibilities.patch Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`. BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead. Upstream Node.js change that prompted this: nodejs/node#47160 Related discussion of BoringSSL support of secure heap: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: work around Node 18 isURL() regression * chore: sort script/node-disabled-tests.json alphabetically * test: add parallel/test-snapshot-argv1 to disabled list test: add parallel/test-snapshot-namespaced-builtin to disabled list We don't support that type of snapshotting at the moment. * chore: disable flaky node test parallel/test-dgram-send-cb-quelches-error fails upstream in v18.x on my box as well * ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set * fixup! fix: work around Node 18 isURL() regression fix: infinite loop regression * fixup! fix: work around Node 18 isURL() regression * chore: patch fixtures/errors/force_colors.snapshot The line numbers in the stacktrace from our v8 build don't match what Node's tests are expecting, so update the stacktrace to match our build. The specific numbers probably aren't t needed for the force_colors test, which is trying to see whether or not the lines are greyed out. One option is to upstream a test change to stop hardcoding the stacktrace. * fixup! fix: work around Node 18 isURL() regression fix; pull in upstream bugfix * fixup! ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set chore: do not inject ELECTRON_RUN_AS_NODE in test-assert-colors.js * chore: disable flaky node test parallel/test-debugger-random-port-with-inspect-port --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Apr 27, 2023

tniessen reviewed Apr 27, 2023

View reviewed changes

deps/histogram/README.md Outdated Show resolved Hide resolved

marco-ippolito marked this pull request as ready for review April 27, 2023 12:25

tniessen reviewed Apr 27, 2023

View reviewed changes

deps/histogram/histogram.gyp Show resolved Hide resolved

marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Apr 28, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2023

This was referenced Apr 29, 2023

CI Reliability 2023-04-29 nodejs/reliability#550

Open

CI Reliability 2023-04-30 nodejs/reliability#551

Open

CI Reliability 2023-05-01 nodejs/reliability#552

Open

This was referenced May 2, 2023

CI Reliability 2023-05-02 nodejs/reliability#553

Open

CI Reliability 2023-05-03 nodejs/reliability#554

Open

github-actions bot mentioned this pull request May 4, 2023

CI Reliability 2023-05-04 nodejs/reliability#555

Open

28 tasks

marco-ippolito mentioned this pull request May 8, 2023

Node.js Security WorkGroup Meeting 2023-05-11 nodejs/security-wg#977

Closed

UlisesGascon approved these changes May 12, 2023

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023

marco-ippolito requested review from tniessen and RafaelGSS May 22, 2023 12:27

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023

tniessen reviewed May 22, 2023

View reviewed changes

marco-ippolito changed the title ~~deps: update histogram to 0.11.7~~ deps: update histogram to 0.11.8 May 22, 2023

deps: update histogram to 0.11.7

6fda056

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2023

nodejs-github-bot closed this May 25, 2023

nodejs-github-bot pushed a commit that referenced this pull request May 25, 2023

deps: update histogram to 0.11.7

dff00ed

PR-URL: #47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

nodejs-github-bot pushed a commit that referenced this pull request May 25, 2023

deps: update histogram 0.11.8

442c352

PR-URL: #47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

marco-ippolito mentioned this pull request May 25, 2023

tools: automate histogram update #48171

Merged

targos pushed a commit that referenced this pull request May 30, 2023

deps: update histogram to 0.11.7

99af671

PR-URL: #47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

targos pushed a commit that referenced this pull request May 30, 2023

deps: update histogram 0.11.8

0db79a0

PR-URL: #47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

github-actions bot mentioned this pull request May 31, 2023

CI Reliability 2023-05-31 nodejs/reliability#582

Open

22 tasks

targos mentioned this pull request Jun 4, 2023

v20.3.0 release proposal #48332

Merged

danielleadams pushed a commit that referenced this pull request Jul 6, 2023

deps: update histogram to 0.11.7

80d6106

PR-URL: #47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

danielleadams pushed a commit that referenced this pull request Jul 6, 2023

deps: update histogram 0.11.8

7a18f5c

PR-URL: #47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023

deps: update histogram to 0.11.7

fbb4b37

PR-URL: nodejs#47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023

deps: update histogram 0.11.8

74206b2

PR-URL: nodejs#47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

ckerr added a commit to electron/electron that referenced this pull request Jul 19, 2023

chore: update build_add_gn_build_files.patch

5d3ecbf

upstream dep histogram 0.11.7 moved its include path from src/ to include/ Xref: nodejs/node#47742

ckerr added a commit to electron/electron that referenced this pull request Jul 25, 2023

chore: update build_add_gn_build_files.patch

022c09f

upstream dep histogram 0.11.7 moved its include path from src/ to include/ Xref: nodejs/node#47742

ckerr added a commit to electron/electron that referenced this pull request Aug 7, 2023

chore: update build_add_gn_build_files.patch

05231b5

upstream dep histogram 0.11.7 moved its include path from src/ to include/ Xref: nodejs/node#47742

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

deps: update histogram to 0.11.7

a53ef9c

PR-URL: nodejs#47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

deps: update histogram 0.11.8

5cb827d

PR-URL: nodejs#47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

deps: update histogram to 0.11.7

554efea

PR-URL: nodejs#47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

deps: update histogram 0.11.8

56e1686

PR-URL: nodejs#47742 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update histogram to 0.11.8 #47742

deps: update histogram to 0.11.8 #47742

marco-ippolito commented Apr 27, 2023 •

edited

tniessen left a comment

marco-ippolito commented Apr 27, 2023 •

edited

nodejs-github-bot commented Apr 28, 2023

nodejs-github-bot commented Apr 28, 2023

nodejs-github-bot commented May 1, 2023

RafaelGSS commented May 3, 2023

UlisesGascon left a comment

marco-ippolito commented May 22, 2023 •

edited

nodejs-github-bot commented May 22, 2023

tniessen May 22, 2023

nodejs-github-bot commented May 25, 2023

deps: update histogram to 0.11.8 #47742

deps: update histogram to 0.11.8 #47742

Conversation

marco-ippolito commented Apr 27, 2023 • edited

tniessen left a comment

Choose a reason for hiding this comment

marco-ippolito commented Apr 27, 2023 • edited

nodejs-github-bot commented Apr 28, 2023

nodejs-github-bot commented Apr 28, 2023

nodejs-github-bot commented May 1, 2023

RafaelGSS commented May 3, 2023

UlisesGascon left a comment

Choose a reason for hiding this comment

marco-ippolito commented May 22, 2023 • edited

nodejs-github-bot commented May 22, 2023

tniessen May 22, 2023

Choose a reason for hiding this comment

nodejs-github-bot commented May 25, 2023

marco-ippolito commented Apr 27, 2023 •

edited

marco-ippolito commented Apr 27, 2023 •

edited

marco-ippolito commented May 22, 2023 •

edited