Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in webstreams.md #47766

Merged
merged 1 commit into from
Apr 28, 2023
Merged

doc: fix typo in webstreams.md #47766

merged 1 commit into from
Apr 28, 2023

Conversation

christiantakle
Copy link
Contributor

@christiantakle christiantakle commented Apr 28, 2023 •
edited

doc: fix arrayBuffer alias typo

buffer was aliased to arrayBuffer in an example for arrayBuffer.

remake of #47762

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 28, 2023
@christiantakle christiantakle mentioned this pull request Apr 28, 2023
Closed
debadree25
debadree25 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@debadree25 debadree25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2023
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2023
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 28, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit c968361 into nodejs:main Apr 28, 2023
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c968361

@Trott
Copy link
Member

Trott commented Apr 28, 2023

Thanks for the contribution! 🚀

yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
@christiantakle @yjl9903
doc: fix typo in webstreams.md
0068aef 
PR-URL: nodejs#47766
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
@christiantakle @targos
doc: fix typo in webstreams.md
253a704 
PR-URL: #47766
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
targos pushed a commit that referenced this pull request May 3, 2023
@christiantakle @targos
doc: fix typo in webstreams.md
d750364 
PR-URL: #47766
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@christiantakle @danielleadams
doc: fix typo in webstreams.md
7771b61 
PR-URL: #47766
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@christiantakle @MoLow
doc: fix typo in webstreams.md
0927c67 
PR-URL: nodejs#47766
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@christiantakle @nodejs-github-bot @Trott @lpinca @BethGriggs @debadree25