meta: fix dependabot commit message #47810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
benjamingr
approved these changes
May 1, 2023
Trott
approved these changes
May 1, 2023
Trott
reviewed
May 1, 2023
| @@ -6,4 +6,6 @@ updates: | |||
| directory: / | |||
| schedule: | |||
| interval: monthly | |||
| commit-message: | |||
| prefix: meta | |||
There was a problem hiding this comment.
In the past, we've used build: for the GitHub Actions stuff, but I'm fine with meta: or build:. Mentioning it in case anyone has a strong opinion about which one we should standardize on.
There was a problem hiding this comment.
I think meta: or tools: are better than build:
There was a problem hiding this comment.
I think tools: would be better to use here over the others for the sake of consistency as we've been using tools: way more than others lately.
There was a problem hiding this comment.
FWIW, I believe the primary reason for using tools: has been that the main logic of recent commits is in tools/dep_updaters/. IMO neither tools: nor build: seems really fitting for GitHub actions that are not directly related to our build process, nor tools that we use outside of GitHub actions.
trivikr
approved these changes
May 2, 2023
lpinca
approved these changes
May 2, 2023
debadree25
added
author ready
tniessen
approved these changes
May 2, 2023
targos
approved these changes
May 2, 2023
VoltrexKeyva
approved these changes
May 2, 2023
VoltrexKeyva
added
the
fast-track
|
Fast-track has been requested by @VoltrexKeyva. Please 👍 to approve. |
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/47810 ✔ Done loading data for nodejs/node/pull/47810 ----------------------------------- PR info ------------------------------------ Title meta: fix dependabot commit message (#47810) Author Mestery (@Mesteery) Branch Mesteery:fix-dependabot-commit -> nodejs:main Labels meta, fast-track, author ready Commits 1 - meta: fix dependabot commit message Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/47810 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47810 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 01 May 2023 20:32:17 GMT ✔ Approvals: 7 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47810#pullrequestreview-1408187594 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47810#pullrequestreview-1408216406 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/47810#pullrequestreview-1408348018 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47810#pullrequestreview-1408421281 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47810#pullrequestreview-1408455779 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47810#pullrequestreview-1408494201 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/47810#pullrequestreview-1408795056 ℹ This PR is being fast-tracked ✘ This PR needs to wait 34 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4860061706 |
nodejs-github-bot
added
the
commit-queue-failed
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ab434d2 |
targos
pushed a commit
that referenced
this pull request
May 3, 2023
PR-URL: #47810 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 3, 2023
PR-URL: #47810 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47810 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47810 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the commits messages of dependabot so it complies with commit message rules :
build(deps): bump actions/checkout from 3.3.0 to 3.5.2->meta: bump actions/checkout from 3.3.0 to 3.5.2.