Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: call ada::idna::to_ascii directly from c++ #47920

Merged
merged 1 commit into from
May 10, 2023
Merged

dns: call ada::idna::to_ascii directly from c++ #47920

merged 1 commit into from
May 10, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 8, 2023 •
edited

Reduces the C++/JS bridge crosses by calling toASCII directly from C++.

Fixes: nodejs/performance#77

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1335/

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 8, 2023
@anonrig
Copy link
Member Author

anonrig commented May 8, 2023 •
edited

@nodejs/net benchmarks/dns does not run the path I've changed and do not show any difference. Do you happen to know which benchmark would show the impact of these changes?

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51700/

tony-go
tony-go approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM codewise 🎉

@anonrig
Copy link
Member Author

anonrig commented May 9, 2023

cc @nodejs/cpp-reviewers

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels May 10, 2023
mcollina
mcollina approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8b5cd32 into main May 10, 2023
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8b5cd32

@nodejs-github-bot nodejs-github-bot deleted the improve-dns branch May 10, 2023 16:04
targos pushed a commit that referenced this pull request May 12, 2023
@anonrig @targos
dns: call ada::idna::to_ascii directly from c++
9be9228 
PR-URL: #47920
Fixes: nodejs/performance#77
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
@ShogunPanda ShogunPanda mentioned this pull request May 31, 2023
Closed
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 4, 2023
@anonrig anonrig mentioned this pull request Aug 16, 2023
Closed
@ruyadorno ruyadorno mentioned this pull request Aug 30, 2023
Merged
targos pushed a commit that referenced this pull request Nov 10, 2023
@anonrig @targos
dns: call ada::idna::to_ascii directly from c++
284a869 
PR-URL: #47920
Fixes: nodejs/performance#77
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
dns: call ada::idna::to_ascii directly from c++
162081d 
PR-URL: nodejs/node#47920
Fixes: nodejs/performance#77
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
dns: call ada::idna::to_ascii directly from c++
3e323da 
PR-URL: nodejs/node#47920
Fixes: nodejs/performance#77
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@tony-go tony-go tony-go approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dns.lookup performance
6 participants
@anonrig @nodejs-github-bot @mcollina @jasnell @tony-go @danielleadams