Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: do not use 'beforeExit' on the main thread #47964

Merged
merged 1 commit into from
May 14, 2023
Merged

esm: do not use 'beforeExit' on the main thread #47964

merged 1 commit into from
May 14, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 11, 2023

Fixes: #47929

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 11, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51773/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit cdd20cf into nodejs:main May 14, 2023
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cdd20cf

@aduh95 aduh95 deleted the beforeExit-main-thread branch May 14, 2023 06:21
@MoLow MoLow mentioned this pull request May 14, 2023
Closed
targos pushed a commit that referenced this pull request May 14, 2023
@aduh95 @targos
esm: do not use 'beforeExit' on the main thread
a7a7eab 
PR-URL: #47964
Fixes: #47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request May 15, 2023
@aduh95 @targos
esm: do not use 'beforeExit' on the main thread
1ec640a 
PR-URL: #47964
Fixes: #47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos mentioned this pull request May 15, 2023
Merged
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 5, 2023
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
esm: do not use 'beforeExit' on the main thread
a31ca4e 
PR-URL: nodejs#47964
Fixes: nodejs#47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
esm: do not use 'beforeExit' on the main thread
8cab32a 
PR-URL: #47964
Backport-PR-URL: #50669
Fixes: #47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: do not use 'beforeExit' on the main thread
85678ab 
PR-URL: nodejs/node#47964
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: do not use 'beforeExit' on the main thread
721b5d9 
PR-URL: nodejs/node#47964
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#47929
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@anonrig anonrig anonrig approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node 20.1.0 --loader seems trigger beforeExit when use await import
7 participants
@aduh95 @nodejs-github-bot @GeoffreyBooth @anonrig @MoLow @targos @danielleadams