Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED #47976

Merged

Conversation

tniessen
Copy link
Member

The error is not necessarily due to a client certificate engine. For example, the privateKeyEngine option might just as well cause this error and is independent of the client certificate.

Also mention that this is likely due to a compile-time option of OpenSSL itself and not due to any particular engine.

The error is not necessarily due to a client certificate engine. For
example, the `privateKeyEngine` option might just as well cause this
error and is independent of the client certificate.

Also mention that this is likely due to a compile-time option of OpenSSL
itself and not due to any particular engine.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels May 12, 2023
@tniessen tniessen added the openssl Issues and PRs related to the OpenSSL dependency. label May 12, 2023
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2023
@tniessen
Copy link
Member Author

cc @nodejs/crypto

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2023
@nodejs-github-bot nodejs-github-bot merged commit 32691bd into nodejs:main May 16, 2023
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 32691bd

targos pushed a commit that referenced this pull request May 30, 2023
The error is not necessarily due to a client certificate engine. For
example, the `privateKeyEngine` option might just as well cause this
error and is independent of the client certificate.

Also mention that this is likely due to a compile-time option of OpenSSL
itself and not due to any particular engine.

PR-URL: #47976
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos targos mentioned this pull request Jun 4, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
The error is not necessarily due to a client certificate engine. For
example, the `privateKeyEngine` option might just as well cause this
error and is independent of the client certificate.

Also mention that this is likely due to a compile-time option of OpenSSL
itself and not due to any particular engine.

PR-URL: #47976
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
The error is not necessarily due to a client certificate engine. For
example, the `privateKeyEngine` option might just as well cause this
error and is independent of the client certificate.

Also mention that this is likely due to a compile-time option of OpenSSL
itself and not due to any particular engine.

PR-URL: nodejs#47976
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants