Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test streambase already has a consumer #48059

Closed
wants to merge 1 commit into from
Closed

test: test streambase already has a consumer #48059

wants to merge 1 commit into from

Conversation

MrJithil
Copy link
Contributor

@MrJithil MrJithil commented May 18, 2023 •
edited

  • test streambase already has a consumer
  • newStreamDuplexFromReadableWritablePair doesn't have a readable prop
  • newStreamDuplexFromReadableWritablePair doesn't have a writable prop

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 18, 2023
@MrJithil MrJithil force-pushed the improve-webstreams-adapters-coverage branch from ae09e10 to d0aeccf Compare May 18, 2023 13:59
@MrJithil MrJithil force-pushed the improve-webstreams-adapters-coverage branch from e38084c to fed96f5 Compare October 7, 2023 02:03
@MrJithil MrJithil force-pushed the improve-webstreams-adapters-coverage branch from fed96f5 to f451c28 Compare October 11, 2023 08:59
@MrJithil MrJithil requested a review from aduh95 October 11, 2023 09:00
@MrJithil MrJithil force-pushed the improve-webstreams-adapters-coverage branch from f451c28 to 9c4697c Compare October 11, 2023 09:21
@MrJithil MrJithil requested a review from aduh95 October 11, 2023 09:21
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2023
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2023
@github-actions
Copy link
Contributor

Failed to start CI
node:internal/modules/cjs/loader:1028
  const err = new Error(message);
              ^

Error: Cannot find module 'call-bind'

Require stack:


    

  • /opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js
    
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1028:15)
    
at Function.Module._load (node:internal/modules/cjs/loader:873:27)
    
at Module.require (node:internal/modules/cjs/loader:1100:19)
    
at require (node:internal/modules/cjs/helpers:119:18)
    
at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js:4:16)
    
at Module._compile (node:internal/modules/cjs/loader:1198:14)
    
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    
at Module.load (node:internal/modules/cjs/loader:1076:32)
    
at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    
at ModuleWrap. (node:internal/modules/esm/translators:169:29) {
    
code: 'MODULE_NOT_FOUND',
    
requireStack: [
    
'/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js'
    
]
    
}
https://github.com/nodejs/node/actions/runs/6480821911

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2023
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@MrJithil MrJithil force-pushed the improve-webstreams-adapters-coverage branch from 9c4697c to 638a73b Compare November 3, 2023 10:05
@MrJithil
test: test streambase has already has a consumer
6ade593 
test: test streambase has already has a consumer
@MrJithil MrJithil force-pushed the improve-webstreams-adapters-coverage branch from 638a73b to 6ade593 Compare November 3, 2023 10:07
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 4, 2023
Open
14 tasks
This was referenced Nov 5, 2023
Open
Open
Open
Open
Open
Open
@MrJithil MrJithil added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2023
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55570/

MrJithil added a commit that referenced this pull request Nov 14, 2023
@MrJithil
test: test streambase has already has a consumer
eb46e09 
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MrJithil
Copy link
Contributor Author

Landed in eb46e09

@MrJithil MrJithil closed this Nov 14, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@MrJithil @targos
test: test streambase has already has a consumer
377dede 
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@MrJithil @martenrichter
test: test streambase has already has a consumer
400871b 
test: test streambase has already has a consumer
PR-URL: nodejs#48059
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@MrJithil @UlisesGascon
test: test streambase has already has a consumer
b67665f 
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@MrJithil @UlisesGascon
test: test streambase has already has a consumer
49e5f47 
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrJithil @nodejs-github-bot @jasnell @aduh95