Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-watch-mode #48147

Merged
merged 1 commit into from Jun 8, 2023
Merged

test: fix flaky test-watch-mode #48147

merged 1 commit into from Jun 8, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented May 23, 2023 •
edited

Fixes: #44898

stress tests: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/402/

also, ran python tools/test.py -J --repeat=500 test/sequential/test-watch-mode locally (macos m1 & windows vm with arm) with no failures

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 23, 2023
@MoLow MoLow added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label May 23, 2023
@MoLow MoLow force-pushed the fix-flaky-test-watch-mode branch 5 times, most recently from fee6ffb to 155d3a0 Compare May 24, 2023 22:38
@MoLow MoLow marked this pull request as ready for review May 24, 2023 22:44
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51961/

This was referenced May 26, 2023
Open
Open
Open
Open
Open
Open
This was referenced Jun 2, 2023
Open
Open
@MoLow MoLow force-pushed the fix-flaky-test-watch-mode branch from 155d3a0 to 3dfe3ce Compare June 7, 2023 20:37
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52151/

@MoLow MoLow marked this pull request as draft June 8, 2023 04:56
@MoLow MoLow force-pushed the fix-flaky-test-watch-mode branch 3 times, most recently from c968d3d to d68b680 Compare June 8, 2023 05:46
@MoLow MoLow force-pushed the fix-flaky-test-watch-mode branch from d68b680 to 078afb8 Compare June 8, 2023 06:15
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2023
@MoLow MoLow marked this pull request as ready for review June 8, 2023 06:20
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52153/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52156/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9dc2d1b into nodejs:main Jun 8, 2023
74 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9dc2d1b

@MoLow MoLow deleted the fix-flaky-test-watch-mode branch June 8, 2023 11:38
This was referenced Jun 11, 2023
Open
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@MoLow @RafaelGSS
test: fix flaky test-watch-mode
7c790ca 
PR-URL: #48147
Fixes: #44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test: fix flaky test-watch-mode
7694e1f 
PR-URL: nodejs#48147
Fixes: nodejs#44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test: fix flaky test-watch-mode
ae0d008 
PR-URL: nodejs#48147
Fixes: nodejs#44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ruyadorno
Copy link
Member

hi @MoLow this is not landing cleanly in v18.x-staging and will need manual backporting.

@ruyadorno ruyadorno added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Aug 29, 2023
MoLow added a commit to MoLow/node that referenced this pull request Sep 3, 2023
@MoLow
test: fix flaky test-watch-mode
de3e181 
PR-URL: nodejs#48147
Fixes: nodejs#44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Sep 3, 2023
@MoLow
test: fix flaky test-watch-mode
bb79fbd 
PR-URL: nodejs#48147
Fixes: nodejs#44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow MoLow added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Sep 3, 2023
ruyadorno pushed a commit to MoLow/node that referenced this pull request Sep 7, 2023
@MoLow @ruyadorno
test: fix flaky test-watch-mode
35943c1 
PR-URL: nodejs#48147
Fixes: nodejs#44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 7, 2023
@MoLow @ruyadorno
test: fix flaky test-watch-mode
4892dc5 
PR-URL: #48147
Backport-PR-URL: #49468
Fixes: #44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 8, 2023
Merged
@ruyadorno ruyadorno added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Sep 9, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@MoLow @ruyadorno
test: fix flaky test-watch-mode
9d90409 
PR-URL: #48147
Backport-PR-URL: #49468
Fixes: #44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-watch-mode (no. 3)
4 participants
@MoLow @nodejs-github-bot @ruyadorno @benjamingr