Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: don't gitignore base64 config.h #48174

Merged
merged 1 commit into from
May 30, 2023
Merged

tools: don't gitignore base64 config.h #48174

merged 1 commit into from
May 30, 2023

Commits on May 25, 2023

  1. tools: don't gitignore base64 config.h 

    The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:

1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing

Fixes: nodejs#47638
    @bnoordhuis
    bnoordhuis committed May 25, 2023
    Configuration menu
    Copy the full SHA
    cb448d5 View commit details
    Browse the repository at this point in the history