Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,vm: clarify usage of cachedData in vm.compileFunction() #48193

Merged
merged 1 commit into from
May 29, 2023
Merged

doc,vm: clarify usage of cachedData in vm.compileFunction() #48193

merged 1 commit into from
May 29, 2023

Conversation

RaisinTen
Copy link
Contributor

Fixes: #48175

@RaisinTen
doc,vm: clarify usage of cachedData in vm.compileFunction()
55706b4 
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels May 26, 2023
@RaisinTen RaisinTen mentioned this pull request May 26, 2023
Closed
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 26, 2023
@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 023e880 into nodejs:main May 29, 2023
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 023e880

@RaisinTen RaisinTen deleted the doc-vm-clarify-usage-of-cachedData-in-compileFunction branch May 29, 2023 01:27
targos pushed a commit that referenced this pull request May 30, 2023
@RaisinTen @targos
doc,vm: clarify usage of cachedData in vm.compileFunction()
802db92 
Fixes: #48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@RaisinTen @danielleadams
doc,vm: clarify usage of cachedData in vm.compileFunction()
71cc43e 
Fixes: #48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@RaisinTen @MoLow
doc,vm: clarify usage of cachedData in vm.compileFunction()
563f9fe 
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RaisinTen @Ceres6
doc,vm: clarify usage of cachedData in vm.compileFunction()
566bba0 
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RaisinTen @Ceres6
doc,vm: clarify usage of cachedData in vm.compileFunction()
8630358 
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48193
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function returned by vm.compileFunction can't accept arguments when cachedData is passed
4 participants
@RaisinTen @nodejs-github-bot @lpinca @debadree25