Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update codeowners with website team #48197

Merged
merged 3 commits into from
May 29, 2023
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented May 26, 2023

This PR updates the CODEOWNERS file to manually ping the Website Team with changes to /tool/doc and /doc/api.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 26, 2023
@tniessen
Copy link
Member

FWIW, /doc/api will create a lot of noise. We already have a @nodejs/documentation team and we don't even ping that team for /doc/api AFAIK.

@ovflowd
Copy link
Member Author

ovflowd commented May 27, 2023

Afaik the @nodejs/documentation team is going to be sunset/removed because of lack of activity?

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 28, 2023
@nodejs-github-bot

This comment was marked as off-topic.

@debadree25 debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 191dce8 into main May 29, 2023
23 checks passed
@nodejs-github-bot nodejs-github-bot deleted the ovflowd-patch-1 branch May 29, 2023 09:22
@nodejs-github-bot
Copy link
Collaborator

Landed in 191dce8

@ovflowd
Copy link
Member Author

ovflowd commented May 29, 2023

Thank you all!

targos pushed a commit that referenced this pull request May 30, 2023
PR-URL: #48197
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #48197
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#48197
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48197
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48197
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants