Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add crypto.create*Key #48284

Merged
merged 1 commit into from Jun 5, 2023
Merged

benchmark: add crypto.create*Key #48284

merged 1 commit into from Jun 5, 2023

Conversation

panva
Copy link
Member

@panva panva commented Jun 1, 2023

Adds crypto.createPrivateKey and crypto.createPublicKey benchmarks for pem, der, and jwk inputs using rsa, ec, and ed25519 key fixtures.

@panva panva added crypto Issues and PRs related to the crypto subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Jun 1, 2023
@panva
Copy link
Member Author

panva commented Jun 1, 2023

cc @nodejs/crypto

tniessen
tniessen approved these changes Jun 2, 2023
View reviewed changes
benchmark/crypto/create-keyobject.js Outdated Show resolved Hide resolved
@tniessen
Copy link
Member

tniessen commented Jun 2, 2023

cc @nodejs/performance

anonrig
anonrig approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with @tniessen's suggestion

benchmark/crypto/create-keyobject.js Outdated Show resolved Hide resolved
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 5, 2023
@panva panva requested review from tniessen and anonrig June 5, 2023 09:58
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6327d45 into nodejs:main Jun 5, 2023
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6327d45

@panva panva deleted the crypto-bench-createKey branch June 5, 2023 16:55
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@panva @RafaelGSS
benchmark: add crypto.create*Key
d6ecbde 
PR-URL: #48284
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@panva @Ceres6
benchmark: add crypto.create*Key
12b730a 
PR-URL: nodejs#48284
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@panva @Ceres6
benchmark: add crypto.create*Key
81aea62 
PR-URL: nodejs#48284
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@panva @ruyadorno
benchmark: add crypto.create*Key
fe9da9d 
PR-URL: #48284
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Aug 29, 2023
Merged
@canova canova mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@H4ad H4ad H4ad approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@panva @tniessen @nodejs-github-bot @jasnell @lpinca @anonrig @H4ad @RafaelGSS