Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: fix for handling on boot timers headers and request #48291

Merged
merged 3 commits into from
Jun 19, 2023
Merged

http: fix for handling on boot timers headers and request #48291

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bc194c
http: fix for handling on boot timers headers and request
franciszek-koltuniuk-red May 31, 2023
cd272a6
update after autochecks
franciszek-koltuniuk-red Jun 7, 2023
fc3c854
update in sourcode: commented the change
franciszek-koltuniuk-red Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/node_http_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,11 +1106,22 @@ void ConnectionsList::Expired(const FunctionCallbackInfo<Value>& args) {
std::swap(headers_timeout, request_timeout);
}

// On IoT or embedded devices the uv_hrtime() may return the timestamp
// that is smaller than configured timeout for headers or request
// to prevent subtracting two unsigned integers
// that can yield incorrect results we should check
// if the 'now' is bigger than the timeout for headers or request
const uint64_t now = uv_hrtime();
const uint64_t headers_deadline =
headers_timeout > 0 ? now - headers_timeout : 0;
(headers_timeout > 0 && now > headers_timeout) ? now - headers_timeout
: 0;
const uint64_t request_deadline =
request_timeout > 0 ? now - request_timeout : 0;
(request_timeout > 0 && now > request_timeout) ? now - request_timeout
: 0;

if (headers_deadline == 0 && request_deadline == 0) {
return args.GetReturnValue().Set(Array::New(isolate, 0));
}

auto iter = list->active_connections_.begin();
auto end = list->active_connections_.end();
Expand Down