Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add preveen-stack to triagers #48387

Merged

Conversation

preveen-stack
Copy link
Contributor

@preveen-stack preveen-stack commented Jun 8, 2023

I have been contributing nodejs ecosystem over the last few years

I would like to get more involved and am looking forward to becoming a contributor

I have read through nodejs code of conduct and promise to adhere to the same 🙏🏽

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 8, 2023
@MoLow
Copy link
Member

MoLow commented Jun 8, 2023

Hey,
I only see this PR and another one you opened:
https://github.com/search?q=org%3Anodejs+author%3Apreveen-stack+&type=pullrequests
the links you added seem to be incorrect

@preveen-stack preveen-stack marked this pull request as ready for review June 8, 2023 06:18
@preveen-stack
Copy link
Contributor Author

@MoLow Thanks for reviewing. I have updated the links. pls check

@aduh95
Copy link
Contributor

aduh95 commented Jun 10, 2023

Any chance you could reword the commit message to comply with our guidelines?

1. The first line should:
* contain a short description of the change (preferably 50 characters or
less, and no more than 72 characters)
* be entirely in lowercase with the exception of proper nouns, acronyms, and
the words that refer to code, like function/variable names
* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline
files/you/changed` to find out what subsystems your changes touch.
Examples:
* `net: add localAddress and localPort to Socket`
* `src: fix typos in async_wrap.h`
2. Keep the second line blank.
3. Wrap all other lines at 72 columns (except for long URLs).

It should look like doc: add preveen-stack to triagers. Let me know if you need help with that.

@preveen-stack preveen-stack changed the title propose preveen-stack as a triager doc: add preveen-stack to triagers Jun 10, 2023
@preveen-stack
Copy link
Contributor Author

Thanks @aduh95. Changed the commit message as per requirement.

@aduh95
Copy link
Contributor

aduh95 commented Jun 10, 2023

@preveen-stack no you changed the PR title :) to change the commit title, you need to use the CLI. Let me know if you need help, I can do it for you if you prefer.

@preveen-stack
Copy link
Contributor Author

@aduh95 if you don't mind, please go ahead and change the commit message. Thanks

@aduh95 aduh95 force-pushed the add-preveen-stack-to-triagers branch from 0c0ca36 to 7def7df Compare June 10, 2023 16:41
@aduh95
Copy link
Contributor

aduh95 commented Jun 15, 2023

Seven days have passed and no objections have been made, this self-nomination has officially passed. Congrats and welcome to the triagers!

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2023
@nodejs-github-bot nodejs-github-bot merged commit c760ff2 into nodejs:main Jun 15, 2023
17 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c760ff2

@gireeshpunathil
Copy link
Member

Congratulations @preveen-stack! I just sent an invitation to you to join the triage team!

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
PR-URL: #48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@ruyadorno ruyadorno mentioned this pull request Sep 8, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48387
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants