tools: update eslint-plugin-jsdoc #48393

richardlau · 2023-06-08T17:32:48Z

Run a subset of tools/dep_updaters/update-eslint.sh to update eslint-plugin-jsdoc to get rid of a spurious ENOENT error when running the linter.

Fixes: #48374

Ran this subset to update -- the script as a whole will exit early because eslint itself hasn't been updated:

node/tools/dep_updaters/update-eslint.sh

Lines 52 to 71 in f2670a6

    
           ( 
        
               cd node_modules/eslint 
        
               "$NODE" "$NPM" install \ 
        
               --ignore-scripts \ 
        
               --install-links=false \ 
        
               --no-bin-links \ 
        
               --no-save \ 
        
               --omit=dev \ 
        
               --omit=peer \ 
        
               eslint-plugin-jsdoc \ 
        
               eslint-plugin-markdown \ 
        
               @babel/core \ 
        
               @babel/eslint-parser \ 
        
               @babel/plugin-syntax-import-assertions 
        
           ) 
        
           # Use dmn to remove some unneeded files. 
        
           "$NODE" "$NPM" exec --package=dmn@2.2.2 --yes -- dmn -f clean 
        
           # TODO: Get this into dmn. 
        
           find node_modules -name .package-lock.json -exec rm {} \; 
        
           find node_modules -name 'README*' -exec rm {} \;

Run a subset of `tools/dep_updaters/update-eslint.sh` to update `eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when running the linter.

github-actions · 2023-06-08T22:24:09Z

Fast-track has been requested by @aduh95. Please 👍 to approve.

nodejs-github-bot · 2023-06-09T03:40:04Z

Landed in da1c9e3

Run a subset of `tools/dep_updaters/update-eslint.sh` to update `eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when running the linter. PR-URL: #48393 Fixes: #48374 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Run a subset of `tools/dep_updaters/update-eslint.sh` to update `eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when running the linter. PR-URL: nodejs#48393 Fixes: nodejs#48374 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Run a subset of `tools/dep_updaters/update-eslint.sh` to update `eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when running the linter. PR-URL: #48393 Fixes: #48374 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

tools: update eslint-plugin-jsdoc

b089ef2

Run a subset of `tools/dep_updaters/update-eslint.sh` to update `eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when running the linter.

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 8, 2023

richardlau mentioned this pull request Jun 8, 2023

ENOENT running JS linter #48374

Closed

debadree25 approved these changes Jun 8, 2023

View reviewed changes

lpinca approved these changes Jun 8, 2023

View reviewed changes

richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2023

VoltrexKeyva approved these changes Jun 8, 2023

View reviewed changes

aduh95 approved these changes Jun 8, 2023

View reviewed changes

aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 8, 2023

MoLow approved these changes Jun 9, 2023

View reviewed changes

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2023

nodejs-github-bot merged commit da1c9e3 into nodejs:main Jun 9, 2023
33 checks passed

richardlau deleted the eslint branch June 9, 2023 07:38

RafaelGSS mentioned this pull request Jul 3, 2023

v20.4.0 proposal #48643

Merged

ruyadorno mentioned this pull request Aug 29, 2023

v18.18.0 proposal #49220

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: update eslint-plugin-jsdoc #48393

tools: update eslint-plugin-jsdoc #48393

richardlau commented Jun 8, 2023 •

edited

github-actions bot commented Jun 8, 2023

nodejs-github-bot commented Jun 9, 2023

	(
	cd node_modules/eslint
	"$NODE" "$NPM" install \
	--ignore-scripts \
	--install-links=false \
	--no-bin-links \
	--no-save \
	--omit=dev \
	--omit=peer \
	eslint-plugin-jsdoc \
	eslint-plugin-markdown \
	@babel/core \
	@babel/eslint-parser \
	@babel/plugin-syntax-import-assertions
	)
	# Use dmn to remove some unneeded files.
	"$NODE" "$NPM" exec --package=dmn@2.2.2 --yes -- dmn -f clean
	# TODO: Get this into dmn.
	find node_modules -name .package-lock.json -exec rm {} \;
	find node_modules -name 'README*' -exec rm {} \;

tools: update eslint-plugin-jsdoc #48393

tools: update eslint-plugin-jsdoc #48393

Conversation

richardlau commented Jun 8, 2023 • edited

github-actions bot commented Jun 8, 2023

nodejs-github-bot commented Jun 9, 2023

richardlau commented Jun 8, 2023 •

edited