Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update create-or-update-pull-request-action #48398

Merged
merged 1 commit into from Jun 9, 2023

Conversation

richardlau
Copy link
Member

Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)


The workflow is currently failing: https://github.com/nodejs/node/actions/runs/5215729249/jobs/9413680952

Run gr2m/create-or-update-pull-request-action@df20b2c073090271599a08c55ae26e0c3522b329
Error: File not found: '/home/runner/work/_actions/gr2m/create-or-update-pull-request-action/df20b2c073090271599a08c55ae26e0c3522b329/dist/index.js'

Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 8, 2023
@richardlau
Copy link
Member Author

Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau
Copy link
Member Author

Workflow run with this PR: https://github.com/nodejs/node/actions/runs/5216284702/jobs/9414851477

This workflow run opened #48399 which looks correct, except because I ran the workflow from the branch from this PR it included the commit from this PR in #48399. I'll close off #48399 and we can rerun the fixed workflow from the main branch once this PR lands.

@bnoordhuis bnoordhuis added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Fast-track has been requested by @bnoordhuis. Please 👍 to approve.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6a3403c into main Jun 9, 2023
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6a3403c

@nodejs-github-bot nodejs-github-bot deleted the update-openssl-workflow branch June 9, 2023 11:54
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)
PR-URL: #48398
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Use the same commit SHA for this action as used in our other workflows.

Refs: nodejs#46169
Refs: nodejs#45022 (comment)
PR-URL: nodejs#48398
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Use the same commit SHA for this action as used in our other workflows.

Refs: nodejs#46169
Refs: nodejs#45022 (comment)
PR-URL: nodejs#48398
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)
PR-URL: #48398
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ruyadorno ruyadorno mentioned this pull request Aug 29, 2023
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
Use the same commit SHA for this action as used in our other workflows.

Refs: #46169
Refs: #45022 (comment)
PR-URL: #48398
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants