Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: make --test-name-pattern recursive #48401

Closed
wants to merge 2 commits into from
Closed

test_runner: make --test-name-pattern recursive #48401

wants to merge 2 commits into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jun 9, 2023

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner labels Jun 9, 2023
benjamingr
benjamingr reviewed Jun 9, 2023
View reviewed changes
test/common/index.js Outdated Show resolved Hide resolved
@MoLow
test: allow using Flags: with spaces
f26b357
@MoLow
test_runner: suppprt passing nested test name pattern
2f36be3 
accept a name parretn with a path to a test with ">" as a separator
@MoLow
Copy link
Member Author

MoLow commented Jun 11, 2023

this seems a little more complicated than I thought - when looking deeper than a single level, closing for now

@MoLow MoLow closed this Jun 11, 2023
@MoLow MoLow deleted the test-runner-arrows branch June 11, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr left review comments

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test runner should allow specific subtest filtering, via --test-name-pattern or otherwise
3 participants
@MoLow @nodejs-github-bot @benjamingr