report: disable js stack when no context is entered #48495
Merged
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
There are no guarantees that the JS stack can be generated when no context is entered.
legendecas
force-pushed
the
canary/node-report-stack
branch
from
04223ff
to
652685b
Compare
|
@nodejs/diagnostics |
gireeshpunathil
approved these changes
Jun 19, 2023
cjihrig
approved these changes
Jun 19, 2023
joyeecheung
approved these changes
Jun 19, 2023
jasnell
approved these changes
Jun 20, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
tony-go
approved these changes
Jun 21, 2023
Flarna
approved these changes
Jun 21, 2023
Flarna
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a509753 |
30 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
There are no guarantees that the JS stack can be generated when no context is entered. PR-URL: #48495 Fixes: nodejs/node-v8#250 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4582948 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
There are no guarantees that the JS stack can be generated when no context is entered. PR-URL: nodejs#48495 Fixes: nodejs/node-v8#250 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4582948 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
There are no guarantees that the JS stack can be generated when no context is entered. PR-URL: nodejs#48495 Fixes: nodejs/node-v8#250 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4582948 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 10, 2023
There are no guarantees that the JS stack can be generated when no context is entered. PR-URL: #48495 Fixes: nodejs/node-v8#250 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4582948 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
There are no guarantees that the JS stack can be generated when no context is entered. PR-URL: #48495 Fixes: nodejs/node-v8#250 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4582948 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no guarantees that the JS stack can be generated when no
context is entered. It is also invalid to call into JS if the current
context is missing.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4582948
Fixes: nodejs/node-v8#250