Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary noop function args to musNotCall() #48513

Merged
merged 2 commits into from Jun 24, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 21, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 21, 2023
@mscdex
Copy link
Contributor

mscdex commented Jun 21, 2023

s/musNotCall/mustNotCall/ in commit message

test: remove unnecessary noop function args to `mustNotCall()`
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 23, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48513
✔  Done loading data for nodejs/node/pull/48513
----------------------------------- PR info ------------------------------------
Title      test: remove unnecessary noop function args to `musNotCall()` (#48513)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:must-not-noop -> nodejs:main
Labels     test, author ready, needs-ci
Commits    2
 - test: remove unnecessary noop function args to `musNotCall()`
 - amend! test: remove unnecessary noop function args to `musNotCall()`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/48513
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Harshitha K P 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48513
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Harshitha K P 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 21 Jun 2023 18:23:06 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48513#pullrequestreview-1491447001
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48513#pullrequestreview-1491730123
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/48513#pullrequestreview-1492586924
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-06-21T21:50:47Z: https://ci.nodejs.org/job/node-test-pull-request/52335/
- Querying data for job/node-test-pull-request/52335/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48513
From https://github.com/nodejs/node
 * branch                  refs/pull/48513/merge -> FETCH_HEAD
✔  Fetched commits as e9340038114f..3eb2f919471f
--------------------------------------------------------------------------------
[main dfb982fc7f] test: remove unnecessary noop function args to `musNotCall()`
 Author: Antoine du Hamel 
 Date: Wed Jun 21 20:18:12 2023 +0200
 14 files changed, 17 insertions(+), 18 deletions(-)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:
git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch main
Your branch is ahead of 'origin/main' by 1 commit.
(use "git push" to publish your local commits)

Cherry-pick currently in progress.
(run "git cherry-pick --continue" to continue)
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)

Untracked files:
(use "git add ..." to include in what will be committed)
labels.json
output

nothing added to commit but untracked files present (use "git add" to track)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/5359408246

@aduh95 aduh95 merged commit d9f394e into nodejs:main Jun 24, 2023
61 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 24, 2023

Landed in d9f394e

@aduh95 aduh95 deleted the must-not-noop branch June 24, 2023 14:16
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48513
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48513
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48513
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
PR-URL: #48513
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 10, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48513
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants