test: deflake test-net-throttle #48599

lpinca · 2023-06-29T13:29:48Z

Sometimes the test completes with only two data chunks received on the
client.

The test is not very resource intensive. It just writes data to a TCP socket until backpressure is reached. Move it parallel.

lpinca · 2023-06-29T13:32:37Z

I've verified this locally in a FreeBSD 12.4 VM by running

python3.9 tools/test.py -j 32 --repeat=1000 test/parallel/test-net-throttle.js

Sometimes the test completes with only two data chunks received on the client. Fixes: nodejs#40507

nodejs-github-bot · 2023-06-29T13:55:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52560/

nodejs-github-bot · 2023-06-29T16:41:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52562/

lpinca · 2023-07-04T16:36:57Z

@nodejs/testing

lpinca · 2023-07-12T10:23:18Z

@nodejs/collaborators sorry for the ping but it's a trivial fix that improves CI reliability.

nodejs-github-bot · 2023-07-12T12:17:21Z

Landed in c2c7260...26bfae5

The test is not very resource intensive. It just writes data to a TCP socket until backpressure is reached. Move it parallel. PR-URL: #48599 Fixes: #40507 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

Sometimes the test completes with only two data chunks received on the client. Fixes: #40507 PR-URL: #48599 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

The test is not very resource intensive. It just writes data to a TCP socket until backpressure is reached. Move it parallel. PR-URL: #48599 Fixes: #40507 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

Sometimes the test completes with only two data chunks received on the client. Fixes: #40507 PR-URL: #48599 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

The test is not very resource intensive. It just writes data to a TCP socket until backpressure is reached. Move it parallel. PR-URL: nodejs#48599 Fixes: nodejs#40507 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

Sometimes the test completes with only two data chunks received on the client. Fixes: nodejs#40507 PR-URL: nodejs#48599 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>