Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: pre-emptively fix tests broken by V8 CL #48671

Closed
wants to merge 2 commits into from

Commits on Jul 6, 2023

  1. src: remove kEagerCompile for CompileFunction

    It wasn't doing anything, and actually enabling it would cause some
    tests to fail.
    
    Refs: nodejs#48576
    kvakil committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    81a2cfe View commit details
    Browse the repository at this point in the history
  2. deps: V8: cherry-pick cb00db4dba6c

    Original commit message:
    
        [compiler] fix CompileFunction ignoring kEagerCompile
    
        v8::ScriptCompiler::CompileFunction was ignoring kEagerCompile. Unlike
        the other functions in v8::ScriptCompiler, it was not actually
        propagating kEagerCompile to the parser. The newly updated test fails
        without this change.
    
        I did some archeology and found that this was commented out since the
        original CL in https://crrev.com/c/980944.
    
        As far as I know Node.js is the main consumer of this particular API.
        This CL speeds up Node.js's overall startup time by ~13%.
    
        Change-Id: Ifc3cd6653555194d46ca48db14f7ba7a4afe0053
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4571822
        Commit-Queue: Marja Hölttä <marja@chromium.org>
        Reviewed-by: Marja Hölttä <marja@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#87944}
    
    Refs: v8/v8@cb00db4
    kvakil committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    64583df View commit details
    Browse the repository at this point in the history