Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make BaseObject iteration order deterministic #48702

Merged
merged 1 commit into from
Jul 12, 2023
Merged

src: make BaseObject iteration order deterministic #48702

merged 1 commit into from
Jul 12, 2023

Commits on Jul 8, 2023

  1. src: make BaseObject iteration order deterministic 

    Previously we just rely on the unordered_set order to iterate over
the BaseObjects, which is not deterministic.

The iteration is only used in printing, verification, and snapshot
generation. In the first two cases the performance overhead of
sorting does not matter because they are only used for debugging.
In the last case the determinism is more important than the trivial
overhead of sorting. So this patch makes the iteration deterministic
by sorting the set first, as what is already being done when we
drain the queue.
    @joyeecheung
    joyeecheung committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    07fdbd5 View commit details
    Browse the repository at this point in the history