Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: save the performance milestone time origin in the AliasedArray #48708

Merged
merged 2 commits into from Jul 20, 2023
Merged

src: save the performance milestone time origin in the AliasedArray #48708

merged 2 commits into from Jul 20, 2023

Commits on Jul 9, 2023

  1. src: save the performance milestone time origin in the AliasedArray 

    Previously we cache the time origin for the milestones in the user
land, and refresh it at pre-execution. As result the time origin
gets serialized into the snapshot and is therefore not deterministic.
Now we store it in the milestone array as an internal value and
reset the milestones at serialization time instead of
deserialization time. This improves the determinism of the snapshot.

Drive-by: remove the unused MarkMilestone() binding.
    @joyeecheung
    joyeecheung committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    4f5801f View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. fixup! src: save the performance milestone time origin in the Aliased… 

    …Array
    @joyeecheung
    joyeecheung committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8740204 View commit details
    Browse the repository at this point in the history