dgram, net: support `Symbol.asyncDispose` #48717

atlowChemi · 2023-07-09T19:34:20Z

No description provided.

nodejs-github-bot · 2023-07-09T19:34:24Z

Review requested:

@nodejs/net

lib/dgram.js

lib/net.js

mcollina

lgtm

nodejs-github-bot · 2023-07-10T02:52:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52678/

nodejs-github-bot · 2023-07-11T14:36:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52701/

MoLow · 2023-07-11T18:34:30Z

@atlowChemi asked me where is the comment of the CI,
so here it is: https://ci.nodejs.org/job/node-test-pull-request/52701/

is seems like we passed the rate limit of the github api

nodejs-github-bot · 2023-07-11T21:00:54Z

Commit Queue failed

- Loading data for nodejs/node/pull/48717 ✔ Done loading data for nodejs/node/pull/48717 ----------------------------------- PR info ------------------------------------ Title dgram, net: support `Symbol.asyncDispose` (#48717) Author Chemi Atlow (@atlowChemi) Branch atlowChemi:dgram-asyncDispose -> nodejs:main Labels dgram, net, author ready, needs-ci Commits 2 - dgram: socket add `asyncDispose` - net: server add `asyncDispose` Committers 1 - atlowChemi PR-URL: https://github.com/nodejs/node/pull/48717 Reviewed-By: Matteo Collina Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48717 Reviewed-By: Matteo Collina Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Jul 2023 19:34:20 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48717#pullrequestreview-1520959501 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48717#pullrequestreview-1524942718 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48717#pullrequestreview-1524737638 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-07-11T18:34:30Z: https://ci.nodejs.org/job/node-test-pull-request/52701/ - Querying data for job/node-test-pull-request/52701/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48717 From https://github.com/nodejs/node * branch refs/pull/48717/merge -> FETCH_HEAD ✔ Fetched commits as ccdfb374383a..4792bdf0582d -------------------------------------------------------------------------------- [main 20437fb365] dgram: socket add `asyncDispose` Author: atlowChemi Date: Mon Jul 10 00:21:58 2023 +0300 3 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 test/parallel/test-dgram-async-dispose.mjs [main a31100b984] net: server add `asyncDispose` Author: atlowChemi Date: Mon Jul 10 00:22:05 2023 +0300 3 files changed, 51 insertions(+), 1 deletion(-) create mode 100644 test/parallel/test-net-server-async-dispose.mjs ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
dgram: socket add asyncDispose

PR-URL: #48717
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

[detached HEAD 11447cd8e4] dgram: socket add asyncDispose
Author: atlowChemi chemi@testim.io
Date: Mon Jul 10 00:21:58 2023 +0300
3 files changed, 41 insertions(+), 1 deletion(-)
create mode 100644 test/parallel/test-dgram-async-dispose.mjs
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
net: server add asyncDispose

PR-URL: #48717
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

[detached HEAD c1e9dc6ce0] net: server add asyncDispose
Author: atlowChemi chemi@testim.io
Date: Mon Jul 10 00:22:05 2023 +0300
3 files changed, 51 insertions(+), 1 deletion(-)
create mode 100644 test/parallel/test-net-server-async-dispose.mjs

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5524812627

nodejs-github-bot · 2023-07-11T21:10:30Z

Landed in ccdfb37...0e9138d

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: nodejs#48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

atlowChemi requested review from benjamingr and MoLow July 9, 2023 19:34

nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jul 9, 2023

MoLow reviewed Jul 9, 2023

View reviewed changes

lib/dgram.js Show resolved Hide resolved

MoLow reviewed Jul 9, 2023

View reviewed changes

lib/net.js Show resolved Hide resolved

MoLow requested a review from ronag July 9, 2023 20:41

atlowChemi force-pushed the dgram-asyncDispose branch from e8206ae to 3fa9db5 Compare July 9, 2023 21:22

mcollina approved these changes Jul 9, 2023

View reviewed changes

MoLow approved these changes Jul 9, 2023

View reviewed changes

atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 10, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2023

benjamingr approved these changes Jul 10, 2023

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 11, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 11, 2023

atlowChemi added 2 commits July 11, 2023 20:00

dgram: socket add asyncDispose

ebe2989

net: server add asyncDispose

4792bdf

atlowChemi force-pushed the dgram-asyncDispose branch from 3fa9db5 to 4792bdf Compare July 11, 2023 17:01

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 11, 2023

benjamingr approved these changes Jul 11, 2023

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 11, 2023

MoLow approved these changes Jul 11, 2023

View reviewed changes

atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2023

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 11, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2023

nodejs-github-bot closed this Jul 11, 2023

nodejs-github-bot pushed a commit that referenced this pull request Jul 11, 2023

dgram: socket add asyncDispose

17f6b8c

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request Jul 11, 2023

net: server add asyncDispose

0e9138d

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

juanarbol pushed a commit that referenced this pull request Jul 13, 2023

dgram: socket add asyncDispose

c47b2cb

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

juanarbol pushed a commit that referenced this pull request Jul 13, 2023

net: server add asyncDispose

cfa69bd

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

juanarbol mentioned this pull request Jul 13, 2023

V20.5.0 proposal #48761

Merged

This was referenced Jul 16, 2023

CI Reliability 2023-07-16 nodejs/reliability#614

Open

CI Reliability 2023-07-17 nodejs/reliability#615

Open

ruyadorno pushed a commit that referenced this pull request Sep 11, 2023

dgram: socket add asyncDispose

8ebec71

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

ruyadorno pushed a commit that referenced this pull request Sep 11, 2023

net: server add asyncDispose

df5013c

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

ruyadorno mentioned this pull request Sep 11, 2023

v18.18.0 proposal #49220

Merged

ruyadorno pushed a commit that referenced this pull request Sep 13, 2023

dgram: socket add asyncDispose

bf75a11

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

ruyadorno pushed a commit that referenced this pull request Sep 13, 2023

net: server add asyncDispose

45c7e5e

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

ruyadorno pushed a commit that referenced this pull request Sep 17, 2023

dgram: socket add asyncDispose

573eb4b

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

ruyadorno pushed a commit that referenced this pull request Sep 17, 2023

net: server add asyncDispose

f892163

PR-URL: #48717 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dgram, net: support `Symbol.asyncDispose` #48717

dgram, net: support `Symbol.asyncDispose` #48717

atlowChemi commented Jul 9, 2023

nodejs-github-bot commented Jul 9, 2023

mcollina left a comment

nodejs-github-bot commented Jul 10, 2023

nodejs-github-bot commented Jul 11, 2023 •

edited by MoLow

MoLow commented Jul 11, 2023

nodejs-github-bot commented Jul 11, 2023

PR-URL: #48717
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

PR-URL: #48717
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Jul 11, 2023

dgram, net: support Symbol.asyncDispose #48717

dgram, net: support Symbol.asyncDispose #48717

Conversation

atlowChemi commented Jul 9, 2023

nodejs-github-bot commented Jul 9, 2023

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jul 10, 2023

nodejs-github-bot commented Jul 11, 2023 • edited by MoLow

MoLow commented Jul 11, 2023

nodejs-github-bot commented Jul 11, 2023

PR-URL: #48717 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

PR-URL: #48717 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Jul 11, 2023

dgram, net: support `Symbol.asyncDispose` #48717

dgram, net: support `Symbol.asyncDispose` #48717

nodejs-github-bot commented Jul 11, 2023 •

edited by MoLow

PR-URL: #48717
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

PR-URL: #48717
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com