test: fix flaky test-string-decode.js on x86 #48750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes flakiness from the mentioned test due to the x86 memory limit
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Jul 12, 2023
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
debadree25
approved these changes
Jul 12, 2023
anonrig
approved these changes
Jul 12, 2023
debadree25
added
the
author ready
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1c66b81 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Removes flakiness from the mentioned test due to the x86 memory limit PR-URL: nodejs#48750 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Removes flakiness from the mentioned test due to the x86 memory limit PR-URL: nodejs#48750 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
Removes flakiness from the mentioned test due to the x86 memory limit PR-URL: nodejs#48750 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
Removes flakiness from the mentioned test due to the x86 memory limit PR-URL: #48750 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 12, 2023
Removes flakiness from the mentioned test due to the x86 memory limit PR-URL: #48750 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Removes flakiness from the mentioned test due to the x86 memory limit PR-URL: #48750 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2023
Removes flakiness from the mentioned test due to the x86 memory limit PR-URL: #48750 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first noticed
test-string-decoderfailing in CI here. Although it failed with VS2022-produced Node.js binaries, when I tested locally I noticed it was coming up with the same failure on VS2019 too. The only constant is that it happens sometimes and only on x86.After investigating, this is what I found: in some cases, this error was thrown instead of the expected one. Further down the call stack, this line is the root of the issue. It uses
std::numeric_limits<size_t>::max()which differs on x64 and x86, so it's much easier for this condition to be fulfilled on x86 than on x64.The change is simple. It just decreases the buffer size on x86. @targos since you worked on this part of the code before (even fixing the same issue in #36795), I'd be glad to hear your opinion on this. To me, it seemed I just changed one magic number with another, but if there is more context to it please share.
This flaky test is the only thing preventing us to enable the JS test suites for
VS2022-x86, so it would be very good to land this ASAP.