Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: node inspect port 0 description when help is printed #48785

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

iloveitaly
Copy link
Contributor

this is not clearly documented anywhere and is an incredibly helpful tool for CLI debugging.

@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Jul 15, 2023
@cola119
Copy link
Member

cola119 commented Jul 20, 2023

@iloveitaly Could you update the commit message to be <= 72 columns?
https://github.com/nodejs/node/actions/runs/5562916073/jobs/10209046034?pr=48785

@lpinca
Copy link
Member

lpinca commented Jul 20, 2023

I wonder if we should also add this and the other options to doc/api/debugger.md.

this is not clearly documented anywhere and is an incredibly
helpful tool for CLI debugging.
@iloveitaly
Copy link
Contributor Author

@cola119 commit msg line size is fixed!

@iloveitaly
Copy link
Contributor Author

@cola119 quick reminder on this one!

@cola119 cola119 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48785
✔  Done loading data for nodejs/node/pull/48785
----------------------------------- PR info ------------------------------------
Title      doc: node inspect port 0 description when help is printed (#48785)
Author     Michael Bianco  (@iloveitaly, first-time contributor)
Branch     iloveitaly:docs-inspect-port -> nodejs:main
Labels     author ready, needs-ci, debugger
Commits    1
 - doc: node inspect port 0 description when help is printed
Committers 1
 - Michael Bianco 
PR-URL: https://github.com/nodejs/node/pull/48785
Reviewed-By: Kohei Ueno 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48785
Reviewed-By: Kohei Ueno 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 15 Jul 2023 15:22:15 GMT
   ✔  Approvals: 2
   ✔  - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/48785#pullrequestreview-1565021811
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48785#pullrequestreview-1539989751
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5783927533

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 7, 2023
@cola119 cola119 added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 7, 2023
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Failed to start CI
- Validating Jenkins credentials
✘  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/5785309084

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Aug 8, 2023
@cola119 cola119 added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 9, 2023
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48785
✔  Done loading data for nodejs/node/pull/48785
----------------------------------- PR info ------------------------------------
Title      doc: node inspect port 0 description when help is printed (#48785)
Author     Michael Bianco  (@iloveitaly, first-time contributor)
Branch     iloveitaly:docs-inspect-port -> nodejs:main
Labels     author ready, request-ci, debugger
Commits    1
 - doc: node inspect port 0 description when help is printed
Committers 1
 - Michael Bianco 
PR-URL: https://github.com/nodejs/node/pull/48785
Reviewed-By: Kohei Ueno 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48785
Reviewed-By: Kohei Ueno 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 15 Jul 2023 15:22:15 GMT
   ✔  Approvals: 2
   ✔  - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/48785#pullrequestreview-1565021811
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48785#pullrequestreview-1539989751
   ✘  GitHub CI is still running
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5815735261

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@cola119 cola119 added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2023
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 merged commit 9497665 into nodejs:main Aug 11, 2023
72 of 76 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Aug 11, 2023

Landed in 9497665

martenrichter pushed a commit to martenrichter/node that referenced this pull request Aug 13, 2023
PR-URL: nodejs#48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
PR-URL: #48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
PR-URL: nodejs#48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
PR-URL: nodejs#48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
PR-URL: #48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
PR-URL: #48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
PR-URL: #48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#48785
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. debugger Issues and PRs related to the debugger subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants