Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] lib: implement AbortSignal.any() #48800

Closed
wants to merge 2 commits into from
Closed

[v18.x backport] lib: implement AbortSignal.any() #48800

wants to merge 2 commits into from

Conversation

atlowChemi
Copy link
Member

@atlowChemi atlowChemi commented Jul 16, 2023 •
edited

Refs: #47821, #48448

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Jul 16, 2023
atlowChemi
atlowChemi commented Jul 16, 2023
View reviewed changes
test/common/wpt.js
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this change is really related / wanted here

@atlowChemi atlowChemi added the abortcontroller Issues and PRs related to the AbortController API label Jul 16, 2023
@atlowChemi
lib: implement AbortSignal.any()
82fe050 
PR-URL: nodejs#47821
Fixes: nodejs#47811
Refs: whatwg/dom#1152
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@atlowChemi
lib: create weakRef only if any signals provided
a30ecab 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@atlowChemi atlowChemi force-pushed the v18-backport-abortSignal.any branch from 4e57bf1 to a30ecab Compare July 17, 2023 04:55
@atlowChemi atlowChemi added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52803/

@atlowChemi atlowChemi mentioned this pull request Jul 17, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@atlowChemi @danielleadams
lib: implement AbortSignal.any()
efaa073 
PR-URL: #47821
Backport-PR-URL: #48800
Fixes: #47811
Refs: whatwg/dom#1152
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@atlowChemi @danielleadams
lib: create weakRef only if any signals provided
156292d 
PR-URL: #48448
Backport-PR-URL: #48800
Fixes: #48419
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams
Copy link
Member

Landed in d002f9b...156292d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

Assignees
No one assigned
Labels
abortcontroller Issues and PRs related to the AbortController API needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atlowChemi @nodejs-github-bot @danielleadams