Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add new TestSream events to custom reporter examples #48903

Merged
merged 1 commit into from
Jul 26, 2023
Merged

doc: add new TestSream events to custom reporter examples #48903

merged 1 commit into from
Jul 26, 2023

Conversation

atlowChemi
Copy link
Member

fixes: #48894

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner labels Jul 24, 2023
@atlowChemi atlowChemi force-pushed the add-new-reporter-events-to-doc branch from 6984ff6 to 9a87191 Compare July 24, 2023 13:15
@atlowChemi atlowChemi requested a review from MoLow July 24, 2023 13:19
@atlowChemi atlowChemi changed the title doc: add new reporter events to custom reporter examples doc: add new TestSream events to custom reporter examples Jul 24, 2023
MoLow
MoLow approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atlowChemi atlowChemi force-pushed the add-new-reporter-events-to-doc branch from 9a87191 to 4b3d964 Compare July 25, 2023 04:11
@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8577740 into nodejs:main Jul 26, 2023
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8577740

@atlowChemi atlowChemi deleted the add-new-reporter-events-to-doc branch July 26, 2023 16:47
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@atlowChemi @Ceres6
doc: add new reporter events to custom reporter examples
a447bdd 
Fixes: nodejs#48894
PR-URL: nodejs#48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@atlowChemi @pluris
doc: add new reporter events to custom reporter examples
f259b2e 
Fixes: nodejs#48894
PR-URL: nodejs#48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@atlowChemi @pluris
doc: add new reporter events to custom reporter examples
97da160 
Fixes: nodejs#48894
PR-URL: nodejs#48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
doc: add new reporter events to custom reporter examples
a951e3b 
Fixes: nodejs#48894
PR-URL: nodejs#48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
doc: add new reporter events to custom reporter examples
7d7c84f 
Fixes: nodejs#48894
PR-URL: nodejs#48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@atlowChemi @UlisesGascon
doc: add new reporter events to custom reporter examples
c53872a 
Fixes: nodejs#48894
PR-URL: nodejs#48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@atlowChemi @RafaelGSS
doc: add new reporter events to custom reporter examples
5268181 
Fixes: #48894
PR-URL: #48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@atlowChemi @RafaelGSS
doc: add new reporter events to custom reporter examples
5173c55 
Fixes: #48894
PR-URL: #48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 28, 2023
@atlowChemi @targos
doc: add new reporter events to custom reporter examples
ec0a6c1 
Fixes: #48894
PR-URL: #48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add new reporter events to custom reporter examples
7777092 
Fixes: nodejs/node#48894
PR-URL: nodejs/node#48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add new reporter events to custom reporter examples
8b12a48 
Fixes: nodejs/node#48894
PR-URL: nodejs/node#48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example Custom Reporter Provides No Output at All When There's a Warning
5 participants
@atlowChemi @nodejs-github-bot @benjamingr @lpinca @MoLow