Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: modify unmatched message in assert(v8-updates) #48911

Closed
wants to merge 1 commit into from

Conversation

pluris
Copy link
Contributor

@pluris pluris commented Jul 25, 2023

It was modified because the messages created by makeAssertMessage did not seem to be unified.

Refs : #38273

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 25, 2023
@richardlau
Copy link
Member

Related to #48862?

@pluris
Copy link
Contributor Author

pluris commented Jul 26, 2023

Checking the file history, I think it's related to #38273, not #48862.

@pluris
Copy link
Contributor Author

pluris commented Aug 12, 2023

I don't think the change is necessary, so I'll close it.

@pluris pluris closed this Aug 12, 2023
@pluris pluris deleted the fix/missing_typo branch August 30, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants