Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: serialize both BaseObject slots #48996

Merged
merged 1 commit into from
Aug 15, 2023

Commits on Aug 2, 2023

  1. src: serialize both BaseObject slots

    We previously only return startup data for the first slot for
    BaseObjects because we can already serialize all the necessary
    information in one go, but slots that do not get special startup
    data would be serialized verbatim which means that the pointer
    addresses are going to be part of the snapshot blob, resulting
    in indeterminism.
    
    This patch updates the serialization routines and capture information
    for both of the two slots - the first slot with type information
    and memory management type (which we can use in the future for
    cppgc-managed objects) and the second slot with data about the
    object itself. This way the embeedder slots can be serialized
    in a reproducible manner in the snapshot.
    joyeecheung committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    152fce6 View commit details
    Browse the repository at this point in the history