build, deps, test, tools: avoid excessive LTO, debug information #49063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
rockdrilla
force-pushed
the
build-flags
branch
2 times, most recently
from
46e78e0
to
8f1e1e3
Compare
|
Maybe I should replace this: # Avoid excessive PGO
['enable_pgo_generate=="true"', {
'cflags!': [ '-fprofile-generate' ],
'ldflags!': [ '-fprofile-generate' ],
}, ],
['enable_pgo_use=="true"', {
'cflags!': [ '-fprofile-use -fprofile-correction' ],
'ldflags!': [ '-fprofile-use -fprofile-correction' ],
}, ],with that? # Avoid excessive PGO
['enable_pgo_generate=="true"', {
'cflags!': [ '<(pgo_generate)' ],
'ldflags!': [ '<(pgo_generate)' ],
}, ],
['enable_pgo_use=="true"', {
'cflags!': [ '<(pgo_use)' ],
'ldflags!': [ '<(pgo_use)' ],
}, ], |
|
One more catch: replace this # Avoid excessive LTO
['enable_lto=="true"', {
'ldflags': [ '-fno-lto' ],
}],with that? # Avoid excessive LTO
['enable_lto=="true"', {
'cflags': [ '-fno-lto' ],
'cflags!': [ '<(lto)' ],
'ldflags': [ '-fno-lto' ],
'ldflags!': [ '<(lto)' ],
}], |
rockdrilla
force-pushed
the
build-flags
branch
from
8f1e1e3
to
2d7f8df
Compare
rockdrilla
changed the title
|
I'd perform more detailed excessive PGO exclusion later (still in progress). |
rockdrilla
force-pushed
the
build-flags
branch
from
2d7f8df
to
90468da
Compare
Don't link intermediate executables with LTO in order to speed up overall build time. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
condition doesn't apply to this target type (introduced in c3cd75d) Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
Don't build intermediate executables with debug information in order to save some disk space during build. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla
force-pushed
the
build-flags
branch
from
90468da
to
c0f001d
Compare
|
friendly ping @bnoordhuis, @jasnell, @mhdawson, @richardlau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: build, deps, tools: avoid excessive LTO #47313
fixes: build, deps, tools: avoid excessive LTO #47313
Signed-off-by: Konstantin Demin rockdrilla@gmail.com