Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fix globalPreload warning #49069

Merged
merged 4 commits into from
Aug 13, 2023
Merged

esm: fix globalPreload warning #49069

merged 4 commits into from
Aug 13, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 8, 2023

Fixes: #49026

Before:

(node:9201) ExperimentalWarning: `globalPreload` will be removed in a future version. Please use `initialize` instead. is an experimental feature and might change at any time

After:

(node:34642) ExperimentalWarning: It is recommended to use `initialize` instead of `globalPreload`, which is an experimental feature and might change at any time

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2023
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Aug 8, 2023
@GeoffreyBooth
Copy link
Member

No, we need to keep the language about it being removed in a future version.

@aduh95
Copy link
Contributor Author

aduh95 commented Aug 8, 2023

No, we need to keep the language about it being removed in a future version.

Why?

@GeoffreyBooth
Copy link
Member

Because it's stronger. It means you must refactor, it's not just a recommendation. They should know that this is coming.

@JakobJingleheimer
Copy link
Contributor

I agree that the existing verbiage is better than the proposal because we're pretty darn sure upgrading is required (whereas the proposal makes it sound like merely a better option).

@aduh95
Copy link
Contributor Author

aduh95 commented Aug 8, 2023

Well we plan to remove it, but we can't know for sure if we are definitely going to remove it.

I agree that the existing verbiage is better than the proposal

Surely you don't mean that, the current warning is not correct English.

@GeoffreyBooth
Copy link
Member

Surely you don't mean that, the current warning is not correct English.

I assume he means that the gist of the current warning is better than the proposed alternative. As in, just fix the grammar error without changing the intent of what we're trying to say.

@JakobJingleheimer
Copy link
Contributor

Surely you don't mean that, the current warning is not correct English.

I assume he means that the gist of the current warning is better than the proposed alternative. As in, just fix the grammar error without changing the intent of what we're trying to say.

Yes, the minor typographic error aside, the current is better information for the user. I think it would be better to correct the current message.

@aduh95
Copy link
Contributor Author

aduh95 commented Aug 8, 2023

Surely you don't mean that, the current warning is not correct English.

I assume he means that the gist of the current warning is better than the proposed alternative. As in, just fix the grammar error without changing the intent of what we're trying to say.

Yes, the minor typographic error aside, the current is better information for the user. I think it would be better to correct the current message.

What would be your suggestion?

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53102/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53268/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023
@aduh95 aduh95 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit b5da2f4 into nodejs:main Aug 13, 2023
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b5da2f4

@aduh95 aduh95 deleted the globalPreload-warning branch August 13, 2023 14:54
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
esm: fix globalPreload warning
54b72f6 
PR-URL: nodejs#49069
Fixes: nodejs#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@aduh95 @RafaelGSS
esm: fix globalPreload warning
87dd150 
PR-URL: #49069
Fixes: #49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@aduh95 @RafaelGSS
esm: fix globalPreload warning
8179751 
PR-URL: nodejs#49069
Fixes: nodejs#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@aduh95 @rluvaton
esm: fix globalPreload warning
d899145 
PR-URL: nodejs#49069
Fixes: nodejs#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
@aduh95 @RafaelGSS
esm: fix globalPreload warning
5016523 
PR-URL: #49069
Fixes: #49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@aduh95 @RafaelGSS
esm: fix globalPreload warning
31442b9 
PR-URL: #49069
Fixes: #49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
esm: fix globalPreload warning
8ec3953 
PR-URL: nodejs#49069
Fixes: nodejs#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
esm: fix globalPreload warning
01ca6d2 
PR-URL: #49069
Backport-PR-URL: #50669
Fixes: #49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: fix globalPreload warning
8f2d402 
PR-URL: nodejs/node#49069
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: fix globalPreload warning
50c10ac 
PR-URL: nodejs/node#49069
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@GeoffreyBooth GeoffreyBooth Awaiting requested review from GeoffreyBooth

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loaders: globalPreload warning is incorrect
6 participants
@aduh95 @nodejs-github-bot @GeoffreyBooth @JakobJingleheimer @atlowChemi @targos