Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: fix compiler warning in node_api.h #49103

Merged
merged 1 commit into from Aug 30, 2023
Merged

node-api: fix compiler warning in node_api.h #49103

merged 1 commit into from Aug 30, 2023

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Aug 11, 2023 •
edited

Fix -Wstrict-prototypes warning from AppleClang 14.0.3.14030022, compiling C.

My team tests our C addon with -Werror and recent changes to node_api.h broke our build.

/Users/runner/.cmake-js/node-arm64/v18.17.0/include/node/node_api.h:33:65: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
typedef int32_t(NAPI_CDECL* node_api_addon_get_api_version_func)();
                                                                ^
                                                                 void
typedef int32_t(NAPI_CDECL* node_api_addon_get_api_version_func)();
                                                                ^
                                                                 void

The break started when the build machines started using node v18.17.0. Builds from a week ago, using node v18.16.1 were successful.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Aug 11, 2023
mhdawson
mhdawson approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53322/

@graebm
node-api: fix compiler warning in node_api.h
9d6783c 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.
This was referenced Aug 15, 2023
Open
Open
Open
Open
gabrielschulhof
gabrielschulhof approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@gabrielschulhof gabrielschulhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graebm
Copy link
Contributor Author

graebm commented Aug 18, 2023

Seems like some tests are being flaky. Should I push an empty commit and force tests to re-run? Or wait for someone else to take care of things?

legendecas
legendecas approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53467/

This was referenced Aug 21, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53494/

@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Open
27 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53526/

This was referenced Aug 24, 2023
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53619/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53624/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9848352 into nodejs:main Aug 30, 2023
55 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9848352

@graebm graebm deleted the fix-strict-prototypes branch August 30, 2023 15:13
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@graebm @UlisesGascon
node-api: fix compiler warning in node_api.h
7a80834 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: #49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
toyobayashi added a commit to toyobayashi/emnapi that referenced this pull request Sep 14, 2023
@toyobayashi
nodejs/node#49103
d7cc080
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@graebm @alexfernandez
node-api: fix compiler warning in node_api.h
f2903e5 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: nodejs#49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
@graebm @targos
node-api: fix compiler warning in node_api.h
48a1b93 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: #49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
node-api: fix compiler warning in node_api.h
df9cf52 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: nodejs/node#49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
node-api: fix compiler warning in node_api.h
3876210 
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
compiling C, targeting arch arm64 (on x86_64 host). I build my C
addon with -Werror and recent changes to node_api.h broke our build.

PR-URL: nodejs/node#49103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@graebm @nodejs-github-bot @gabrielschulhof @legendecas @mhdawson