crypto: remove getDefaultEncoding() #49170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
blocked
|
Review requested:
|
nodejs-github-bot
added
crypto
benjamingr
approved these changes
Aug 14, 2023
panva
approved these changes
Aug 14, 2023
Refs: nodejs#47182 Refs: nodejs#47869 Refs: nodejs#47943 Refs: nodejs#47998 Refs: nodejs#49140 Refs: nodejs#49145 Refs: nodejs#49167 Refs: nodejs#49169
tniessen
force-pushed
the
lazy-transform-inline-defaultencoding
branch
from
d66373c
to
d4a91a8
Compare
|
Rebased without changes. Should finally be ready 🎉 |
tniessen
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
26 tasks
mcollina
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49170 ✔ Done loading data for nodejs/node/pull/49170 ----------------------------------- PR info ------------------------------------ Title crypto: remove getDefaultEncoding() (#49170) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:lazy-transform-inline-defaultencoding -> nodejs:main Labels crypto, author ready, dont-land-on-v16.x, dont-land-on-v18.x Commits 1 - crypto: remove getDefaultEncoding() Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/49170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Filip Skokan Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Filip Skokan Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 14 Aug 2023 15:34:10 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49170#pullrequestreview-1577123209 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/49170#pullrequestreview-1577153635 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49170#pullrequestreview-1581964409 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-08-16T18:27:49Z: https://ci.nodejs.org/job/node-test-pull-request/53387/ - Querying data for job/node-test-pull-request/53387/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5888089208 |
tniessen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49170 ✔ Done loading data for nodejs/node/pull/49170 ----------------------------------- PR info ------------------------------------ Title crypto: remove getDefaultEncoding() (#49170) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:lazy-transform-inline-defaultencoding -> nodejs:main Labels crypto, author ready, dont-land-on-v16.x, dont-land-on-v18.x Commits 1 - crypto: remove getDefaultEncoding() Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/49170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Filip Skokan Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Filip Skokan Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 14 Aug 2023 15:34:10 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49170#pullrequestreview-1577123209 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/49170#pullrequestreview-1577153635 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49170#pullrequestreview-1581964409 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-08-17T07:37:29Z: https://ci.nodejs.org/job/node-test-pull-request/53387/ - Querying data for job/node-test-pull-request/53387/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5889450757 |
|
GitHub says "All checks have passed - 3 skipped and 49 successful checks" but the bot says "Last GitHub CI failed" 😕 |
lpinca
approved these changes
Aug 17, 2023
32 tasks
debadree25
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49170 ✔ Done loading data for nodejs/node/pull/49170 ----------------------------------- PR info ------------------------------------ Title crypto: remove getDefaultEncoding() (#49170) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:lazy-transform-inline-defaultencoding -> nodejs:main Labels crypto, author ready, dont-land-on-v16.x, dont-land-on-v18.x Commits 1 - crypto: remove getDefaultEncoding() Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/49170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Filip Skokan Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Filip Skokan Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 14 Aug 2023 15:34:10 GMT ✔ Approvals: 4 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49170#pullrequestreview-1577123209 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/49170#pullrequestreview-1577153635 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49170#pullrequestreview-1581964409 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49170#pullrequestreview-1583277504 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-08-17T10:01:18Z: https://ci.nodejs.org/job/node-test-pull-request/53387/ - Querying data for job/node-test-pull-request/53387/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5910128960 |
|
How weird |
debadree25
pushed a commit
that referenced
this pull request
Aug 19, 2023
Refs: #47182 Refs: #47869 Refs: #47943 Refs: #47998 Refs: #49140 Refs: #49145 Refs: #49167 Refs: #49169 PR-URL: #49170 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 78842cf |
debadree25
removed
the
commit-queue-failed
This was referenced Aug 21, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Refs: #47182 Refs: #47869 Refs: #47943 Refs: #47998 Refs: #49140 Refs: #49145 Refs: #49167 Refs: #49169 PR-URL: #49170 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #47182, #47869, #47943, #47998, #49140, #49145, #49167, and #49169. All of these changes can be merged into Node.js 20.
Out of caution, we are not going to remove the last remaining occurrence, which is in
lazy_transform.js, in Node.js 20 (see #49140). However, to minimize the non-backportable patch, this commit inlinesgetDefaultEncoding()by replacing the call with the constant'buffer'. #49140 then simply needs to drop those three lines, but the function itself can be removed on the main branch and in both Node.js 20 and in Node.js 21.