Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.18.0 proposal #49220

Merged
merged 164 commits into from
Sep 18, 2023
Merged

v18.18.0 proposal #49220

merged 164 commits into from
Sep 18, 2023

Commits on Aug 9, 2023

  1. test: delete test-net-bytes-per-incoming-chunk-overhead

    The test's assumptions about RSS are no longer valid, at least with
    Fedora 38.
    
    Closes: #48490
    PR-URL: #48811
    Fixes: #48490
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and RafaelGSS committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    e7d2e8e View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. net: add autoSelectFamily global getter and setter

    PR-URL: #45777
    Backport-PR-URL: #49016
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ShogunPanda authored and ruyadorno committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    863bdb7 View commit details
    Browse the repository at this point in the history
  2. net: fix family autoselection timeout handling

    PR-URL: #47860
    Backport-PR-URL: #49016
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ShogunPanda authored and ruyadorno committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    e8289a8 View commit details
    Browse the repository at this point in the history
  3. net: fix address iteration with autoSelectFamily

    When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
    try connecting to both IPv4 and IPv6, interleaving the address types.
    Instead, it appears that the array that holds the addresses in the order
    they should be attempted was never used after being populated.
    
    PR-URL: #48258
    Backport-PR-URL: #49016
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    indutny authored and ruyadorno committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d3637cd View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64

    Add linux64-loongarch64 into Makefile
    And run make
    
    PR-URL: #46401
    Backport-PR-URL: #48135
    Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
    Reviewed-By: James M Snell jasnell@gmail.com
    Reviewed-By: Michael Dawson midawson@redhat.com
    shipujin authored and ruyadorno committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f4617a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. src: replace idna functions with ada::idna

    Co-authored-by: Daniel Lemire <daniel@lemire.me>
    PR-URL: #47735
    Backport-PR-URL: #48873
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    2 people authored and ruyadorno committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    e426180 View commit details
    Browse the repository at this point in the history
  2. test: validate host with commas on url.parse

    PR-URL: #48878
    Backport-PR-URL: #48873
    Refs: #48873
    Refs: #48855
    Refs: #48850
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    anonrig authored and ruyadorno committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    2de9868 View commit details
    Browse the repository at this point in the history
  3. lib: remove invalid parameter to toASCII

    PR-URL: #48878
    Backport-PR-URL: #48873
    Refs: #48873
    Refs: #48855
    Refs: #48850
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    anonrig authored and ruyadorno committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    69aaf8b View commit details
    Browse the repository at this point in the history
  4. url: ensure getter access do not mutate observable symbols

    PR-URL: #48897
    Backport-PR-URL: #48891
    Refs: #48891
    Refs: #48886
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and ruyadorno committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    0beb5ab View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. net: rework autoSelectFamily implementation

    PR-URL: #46587
    Backport-PR-URL: #49183
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ShogunPanda authored and ruyadorno committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    267439f View commit details
    Browse the repository at this point in the history
  2. net: fix family autoselection SSL connection handling

    PR-URL: #48189
    Backport-PR-URL: #49183
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    ShogunPanda authored and ruyadorno committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    b5f53d9 View commit details
    Browse the repository at this point in the history
  3. test: move test-tls-autoselectfamily-servername to test/internet

    And switch from `google.com` to `nodejs.org`.
    
    PR-URL: #47029
    Backport-PR-URL: #49183
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    aduh95 authored and ruyadorno committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6de7aa1 View commit details
    Browse the repository at this point in the history
  4. tls: fix bugs of double TLS

    Fixs two issues in `TLSWrap`, one of them is reported in
    #30896.
    
    1. `TLSWrap` has exactly one `StreamListener`, however,
    that `StreamListener` can be replaced. We have not been
    rigorous enough here: if an active write has not been
    finished before the transition, the finish callback of it
    will be wrongly fired the successor `StreamListener`.
    
    2. A `TLSWrap` does not allow more than one active write,
    as checked in the assertion about current_write in
    `TLSWrap::DoWrite()`.
    
    However, when users make use of an existing `tls.TLSSocket`
    to establish double TLS, by
    either
      tls.connect({socket: tlssock})
    or
      tlsServer.emit('connection', tlssock)
    we have both of the user provided `tls.TLSSocket`, tlssock and
    a brand new created `TLSWrap` writing to the `TLSWrap` bound to
    tlssock, which easily violates the constranint because two writers
    have no idea of each other.
    
    The design of the fix is:
    when a `TLSWrap` is created on top of a user provided socket,
    do not send any data to the socket until all existing writes
    of the socket are done and ensure registered callbacks of
    those writes can be fired.
    
    PR-URL: #48969
    Backport-PR-URL: #49183
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    ywave620 authored and ruyadorno committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    3eeca52 View commit details
    Browse the repository at this point in the history
  5. esm: fix specifier resolution and symlinks

    Ensure `--experimental-specifier-resolution=node` works when combined
    with `--preserve-symlinks`.
    
    PR-URL: #47674
    Refs: #47649
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    znewsham authored and ruyadorno committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    a00464e View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. test: fix test-net-autoselectfamily for kernel without IPv6 support

    PR-URL: #45856
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    LiviaMedeiros authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c728b8a View commit details
    Browse the repository at this point in the history
  2. benchmark: add crypto.create*Key

    PR-URL: #48284
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    panva authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    fe9da9d View commit details
    Browse the repository at this point in the history
  3. test: update user-timing web-platform tests

    PR-URL: #48321
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    anonrig authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3da57d1 View commit details
    Browse the repository at this point in the history
  4. build: update action to close stale PRs

    My original plan of adding a lable to limit those initially
    process as outlined in #48051
    does not work I think because adding a lable updates the last
    update time.
    
    - Removing the need for the lable
    - Remove the cron scheduling so that it only runs when I run it manually
    - Fix the display name for the action as I missed updating that after
      cut and paste from existing action
    
    The plan will be to find stop dates that should only affect a reasonable
    number of PRs at a time and then run in batches using that instead.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #48196
    Reviewed-By: Mestery <mestery@protonmail.com>
    mhdawson authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    211a4f8 View commit details
    Browse the repository at this point in the history
  5. benchmark: refactor crypto oneshot

    PR-URL: #48267
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    panva authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4f74be3 View commit details
    Browse the repository at this point in the history
  6. test: update FileAPI web-platform tests

    PR-URL: #48322
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e9ac111 View commit details
    Browse the repository at this point in the history
  7. test: update encoding web-platform tests

    PR-URL: #48320
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    125bca6 View commit details
    Browse the repository at this point in the history
  8. tools: disable jsdoc/no-defaults rule

    PR-URL: #48328
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    lpinca authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2eb13e3 View commit details
    Browse the repository at this point in the history
  9. tools: update eslint to 8.42.0

    PR-URL: #48328
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    6a58054 View commit details
    Browse the repository at this point in the history
  10. test: refactor test-gc-http-client-timeout

    Due to server response delay, all possible requests are created anyway.
    Instead of doing `36 * os.availableParallelism()` requests, use a fixed
    number.
    
    Refs: #48078 (comment)
    PR-URL: #48292
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    lpinca authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    41d1e68 View commit details
    Browse the repository at this point in the history
  11. test: ignore the copied entry_point.c

    Add `test_cannot_run_js/entry_point.c` to
    `test/js-native-api/.gitignore`.
    
    PR-URL: #48297
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    lpinca authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f35c4d3 View commit details
    Browse the repository at this point in the history
  12. deps: update zlib to 982b036

    PR-URL: #48327
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    38f6e0d View commit details
    Browse the repository at this point in the history
  13. doc: run license-builder

    PR-URL: #48336
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    github-actions[bot] authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    0651358 View commit details
    Browse the repository at this point in the history
  14. module: reduce url invocations in esm/load.js

    PR-URL: #48337
    Refs: nodejs/performance#92
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    anonrig authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    bf1525c View commit details
    Browse the repository at this point in the history
  15. test_runner: refactor coverage report output for readability

    Add a "table" parameter to getCoverageReport.
    Keep the tap coverage output intact.
    Change the output by adding padding and truncating the tables' cells.
    Add separation lines for table head/body/foot.
    Group uncovered lines as ranges.
    Add yellow color for coverage between 50 and 90.
    
    Refs: #46674
    PR-URL: #47791
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    dmnsgn authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f302286 View commit details
    Browse the repository at this point in the history
  16. deps: update ada to 2.5.1

    PR-URL: #48319
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a2964a4 View commit details
    Browse the repository at this point in the history
  17. test: update url web-platform tests

    PR-URL: #48319
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    anonrig authored and ruyadorno committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    cb92c4b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. url: conform to origin getter spec changes

    PR-URL: #48319
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    anonrig authored and ruyadorno committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    f59c963 View commit details
    Browse the repository at this point in the history
  2. deps: update simdutf to 3.2.14

    PR-URL: #48344
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    3c03ec0 View commit details
    Browse the repository at this point in the history
  3. deps: upgrade npm to 9.7.1

    PR-URL: #48378
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Luke Karrys <luke@lukekarrys.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    npm-cli-bot authored and ruyadorno committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    555982c View commit details
    Browse the repository at this point in the history
  4. tools: update eslint-plugin-jsdoc

    Run a subset of `tools/dep_updaters/update-eslint.sh` to update
    `eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when
    running the linter.
    
    PR-URL: #48393
    Fixes: #48374
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    richardlau authored and ruyadorno committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    590a072 View commit details
    Browse the repository at this point in the history
  5. tools: update create-or-update-pull-request-action

    Use the same commit SHA for this action as used in our other workflows.
    
    Refs: #46169
    Refs: #45022 (comment)
    PR-URL: #48398
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    richardlau authored and ruyadorno committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    01bc10d View commit details
    Browse the repository at this point in the history
  6. test: add missing <algorithm> include for std::find

    GCC 14 drops some transitive includes within libstdc++.
    
    Explicitly include <algorithm> for std::find.
    
    Signed-off-by: Sam James <sam@gentoo.org>
    PR-URL: #48380
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    thesamesam authored and ruyadorno committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    27a4bc7 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. lib: add support for inherited custom inspection methods

    PR-URL: #48306
    Fixes: #48207
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and ruyadorno committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5260f53 View commit details
    Browse the repository at this point in the history
  2. perf_hooks: convert maxSize to IDL value in setResourceTimingBufferSize

    ECMAScript values of WebIDL interface parameters should be converted to
    IDL representatives before the actual implementation, as defined in step
    11.5 of the WebIDL Overload resolution algorithm.
    
    Backport-PR-URL: #45829
    Refs: https://webidl.spec.whatwg.org/#dfn-create-operation-function
    Refs: https://webidl.spec.whatwg.org/#es-overloads
    PR-URL: #44902
    Reviewed-By: James M Snell <jasnell@gmail.com>
    legendecas authored and ruyadorno committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    121f74c View commit details
    Browse the repository at this point in the history
  3. deps: add loong64 config into openssl gypi

    Backport-PR-URL: #49192
    PR-URL: #48043
    Reviewed-By: Michael Dawson midawson@redhat.com
    shipujin authored and ruyadorno committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    3be5335 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. url: add value argument to has and delete methods

    The change aims to add value argument to two methods of URLSearchParams
    class i.e the has method and the delete method. For has method, if
    value argument is provided, then use it to check for presence. For
    delete method, if value argument provided, use it to delete.
    
    Fixes: #47883
    PR-URL: #47885
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    sankalp1999 authored and ruyadorno committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    c59ae86 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. test_runner: make --test-name-pattern recursive

    PR-URL: #48382
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    MoLow authored and ruyadorno committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    7051caf View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. src: handle wasm out of bound in osx will raise SIGBUS correctly

    fix: #46559
    OSX will raise both SIGBUS and SIGSEGV when out of bound memory visit,
    This commit set sigaction in OSX for two signals to handle this.
    
    PR-URL: #46561
    Fixes: #46559
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    HerrCai0907 authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6c72622 View commit details
    Browse the repository at this point in the history
  2. doc: fix typo in events.md

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #48436
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RaisinTen authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ffece88 View commit details
    Browse the repository at this point in the history
  3. doc: add link for news from security wg

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #48396
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    mhdawson authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5cc6eee View commit details
    Browse the repository at this point in the history
  4. doc: add additional info on TSFN dispatch

    Refs: #48356
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #48367
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    mhdawson authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2a561ae View commit details
    Browse the repository at this point in the history
  5. test: fix flaky test-watch-mode

    PR-URL: #48147
    Backport-PR-URL: #49468
    Fixes: #44898
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9d90409 View commit details
    Browse the repository at this point in the history
  6. stream: fix deadlock when pipeing to full sink

    When piping a paused Readable to a full Writable we didn't
    register a drain listener which cause the src to never
    resume.
    
    Refs: #48666
    PR-URL: #48691
    Backport-PR-URL: #49323
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ronag authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c224e1b View commit details
    Browse the repository at this point in the history
  7. esm: add --import flag

    PR-URL: #43942
    Backport-PR-URL: #49539
    Fixes: #40110
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c39b7c2 View commit details
    Browse the repository at this point in the history
  8. doc: mark --import as experimental

    PR-URL: #44067
    Backport-PR-URL: #49539
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    MoLow authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    239b4ea View commit details
    Browse the repository at this point in the history
  9. deps: update corepack to 0.18.1

    PR-URL: #48483
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5e1eb45 View commit details
    Browse the repository at this point in the history
  10. deps: update corepack to 0.19.0

    PR-URL: #48540
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7f7a125 View commit details
    Browse the repository at this point in the history
  11. deps: update ada to 2.6.0

    PR-URL: #48896
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    104b58f View commit details
    Browse the repository at this point in the history
  12. deps: upgrade npm to 9.7.2

    PR-URL: #48514
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    npm-cli-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4a6177d View commit details
    Browse the repository at this point in the history
  13. deps: upgrade npm to 9.8.0

    PR-URL: #48665
    Reviewed-By: Luke Karrys <luke@lukekarrys.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    npm-cli-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d9ff473 View commit details
    Browse the repository at this point in the history
  14. deps: upgrade npm to 9.8.1

    PR-URL: #48838
    Reviewed-By: Luke Karrys <luke@lukekarrys.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    npm-cli-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9cf8fe6 View commit details
    Browse the repository at this point in the history
  15. crypto: remove OPENSSL_FIPS guard for OpenSSL 3

    The OPENSSL_FIPS guard is only needed for versions of OpenSSL earlier
    than 3.0.
    
    Removing the guard for OpenSSL 3 fixes `parallel/test-crypto-fips`
    when run with a FIPS enabled OpenSSL 3 configuration.
    
    PR-URL: #48392
    Refs: #48379
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    richardlau authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b2bc839 View commit details
    Browse the repository at this point in the history
  16. deps: update zlib to 1.2.13.1-motley-3ca9f16

    PR-URL: #48413
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f0e2e3c View commit details
    Browse the repository at this point in the history
  17. crypto: update root certificates to NSS 3.90

    This is the certdata.txt[0] from NSS 3.90, released on 2023-04-06.
    
    This is the version of NSS that shipped in Firefox 113 on
    2023-05-09.
    
    Certificates added:
    - BJCA Global Root CA1
    - BJCA Global Root CA2
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_90_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: #48416
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    dd8cd97 View commit details
    Browse the repository at this point in the history
  18. doc: add kvakil to collaborators

    ...and remove them triagers
    
    Fixes: #48155
    PR-URL: #48449
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    kvakil authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a30f2fb View commit details
    Browse the repository at this point in the history
  19. node-api: implement external strings

    Introduce APIs that allow for the creation of JavaScript strings without
    copying the underlying native string into the engine. The APIs fall back
    to regular string creation if the engine's external string APIs are
    unavailable. In this case, an optional boolean out-parameter indicates
    that the string was copied, and the optional finalizer is called if
    given.
    
    PR-URL: #48339
    Fixes: #48198
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
    gabrielschulhof authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    feb6a54 View commit details
    Browse the repository at this point in the history
  20. doc: refine when file is undefined in test events

    PR-URL: #48451
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    MoLow authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    820aa55 View commit details
    Browse the repository at this point in the history
  21. tools: update lint-md-dependencies

    - `@rollup/plugin-commonjs@25.0.1`
    - `rollup@3.24.1`
    
    PR-URL: #48417
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    538f388 View commit details
    Browse the repository at this point in the history
  22. doc: add preveen-stack to triagers

    PR-URL: #48387
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    preveen-stack authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7575d8b View commit details
    Browse the repository at this point in the history
  23. doc: revise error.md introduction

    PR-URL: #48423
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    aduh95 authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3cf3fb9 View commit details
    Browse the repository at this point in the history
  24. node-api: provide napi_define_properties fast path

    Implement defining properties via V8's
    `v8::Object::CreateDataProperty()`, which is faster for data-valued,
    writable, configurable, and enumerable properties.
    
    Re: #45905
    Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
    PR-URL: #48440
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    gabrielschulhof authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    04dc090 View commit details
    Browse the repository at this point in the history
  25. doc: update fs flags documentation

    PR-URL: #48463
    Fixes: #48452
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    sinkhaha authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0056cb9 View commit details
    Browse the repository at this point in the history
  26. tools: prepare tools/doc for to-vfile 8.0.0

    toVFile.readSync() is removed in favor of readSync().
    
    PR-URL: #48485
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Trott authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    79dcd96 View commit details
    Browse the repository at this point in the history
  27. tools: update doc to to-vfile@8.0.0

    PR-URL: #48485
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9449f05 View commit details
    Browse the repository at this point in the history
  28. tools: update eslint to 8.43.0

    PR-URL: #48487
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9c1937c View commit details
    Browse the repository at this point in the history
  29. http: fix for handling on boot timers headers and request

    This change is a fix for handling headersTimeout and requestTimeout
    that causes unexpected behavior if the HTTP server is started on boot:
    
     - the connections to the server can be closed immediately
       with the status HTTP 408
    
    This issue usually happens on IoT or embedded devices where
    the reference timestamp (returned by uv_hrtime()) is counted since boot
    and can be smaller than the headersTimeout or the requestTimeout value.
    
    Additionally added performance improvement to process the list of
    connection only if one of the timers should be processed
    
    PR-URL: #48291
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    franciszek-koltuniuk-red authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    977e9a3 View commit details
    Browse the repository at this point in the history
  30. doc: link to Runtime Keys in export conditions

    This commit:
    1. Adds a link to the WinterCG Runtime Keys proposal draft spec in the
        documentation for the `export` condition.
    2. Adds a criteria to add more export conditions to the Node.js docs:
        they should be Node.js core-relevant.
    3. Removes the "deno" and "react-native" export conditions from the core
        docs with the expectation that readers will follow the link to the
        Runtime Keys proposal draft spec to learn about them and more.
    
    PR-URL: #48408
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jcbhmr authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f8ba672 View commit details
    Browse the repository at this point in the history
  31. tools: replace sed with perl

    For cross-platform compatibility use perl instead of sed.
    
    Fixes: #48496
    PR-URL: #48499
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    lpinca authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9711bc2 View commit details
    Browse the repository at this point in the history
  32. report: disable js stack when no context is entered

    There are no guarantees that the JS stack can be generated when no
    context is entered.
    
    PR-URL: #48495
    Fixes: nodejs/node-v8#250
    Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4582948
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    legendecas authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    07065d0 View commit details
    Browse the repository at this point in the history
  33. test: skip test-runner-watch-mode on IBMi

    PR-URL: #48473
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    MoLow authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8fdd4c5 View commit details
    Browse the repository at this point in the history
  34. tools: update lint-md-dependencies

    Updates: rollup@3.25.1 to-vfile@8.0.0 vfile-reporter@8.0.0
    PR-URL: #48486
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e168eab View commit details
    Browse the repository at this point in the history
  35. http: remove useless ternary in test

    PR-URL: #48481
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    LockingReal authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d47eb73 View commit details
    Browse the repository at this point in the history
  36. doc: add vmoroz to collaborators

    PR-URL: #48527
    Fixes: #48388
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    vmoroz authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e8dc7bd View commit details
    Browse the repository at this point in the history
  37. doc: update security-release-process.md

    PR-URL: #48504
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    RafaelGSS authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e1339d5 View commit details
    Browse the repository at this point in the history
  38. src: refactor SplitString in util

    PR-URL: #48491
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    anonrig authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0d73009 View commit details
    Browse the repository at this point in the history
  39. deps: update icu to 73.2

    PR-URL: #48502
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1b960d9 View commit details
    Browse the repository at this point in the history
  40. typings: remove unused primordials

    PR-URL: #48509
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3363cfa View commit details
    Browse the repository at this point in the history
  41. module: add SourceMap.findOrigin

    This adds the `SourceMap.findOrigin(lineNumber, columnNumber)` method,
    for finding the origin source file and 1-indexed line and column numbers
    corresponding to the 1-indexed line and column numbers from a call site
    in generated source code.
    
    Fix: #47770
    PR-URL: #47790
    Fixes: #47770
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    isaacs authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    071eaad View commit details
    Browse the repository at this point in the history
  42. doc: unnest mime and MIMEParams from MIMEType constructor

    PR-URL: #47950
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Semigradsky authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1fe75dc View commit details
    Browse the repository at this point in the history
  43. doc: fix filename type in watch result

    PR-URL: #48032
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Semigradsky authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e2f3ed1 View commit details
    Browse the repository at this point in the history
  44. lib: reduce url getters on makeRequireFunction

    PR-URL: #48492
    Refs: nodejs/performance#92
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5d682c5 View commit details
    Browse the repository at this point in the history
  45. stream: fix premature pipeline end

    Fixes: #48406
    PR-URL: #48435
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    ronag authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    786fbdb View commit details
    Browse the repository at this point in the history
  46. test: remove unnecessary noop function args to mustNotCall()

    PR-URL: #48513
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    13ac0a5 View commit details
    Browse the repository at this point in the history
  47. test: define NAPI_VERSION before including node_api.h

    Include node.h first to define NAPI_VERSION that node binary is built
    with. The node.h should also be included first in embedder's use case
    since it is the primary header file.
    
    PR-URL: #48376
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    legendecas authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f2ce8e0 View commit details
    Browse the repository at this point in the history
  48. doc: add description of autoAllocateChunkSize in ReadableStream

    Refs: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream/ReadableStream
    PR-URL: #48004
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    debadree25 authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f18b287 View commit details
    Browse the repository at this point in the history
  49. test: make IsolateData per-isolate in cctest

    This ensures that we only create one IsolateData for each isolate
    inthe cctest, since IsolateData are meant to be per-isolate.
    We need to make the isolate and isolate_data static in the
    test fixtures as a result, similar to how the event loops and
    array buffer allocators are managed in the
    NodeZeroIsolateTestFixture but it is fine because gtest ensures
    that the Setup() and TearDown() of the fixtures are always run
    in order and would never overlap in one process.
    
    PR-URL: #48450
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3ae96ae View commit details
    Browse the repository at this point in the history
  50. fs: remove unneeded return statement

    The `writable._write()` implementation does not need to return anything,
    only call the callback.
    
    PR-URL: #48526
    Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    lpinca authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c3a27d1 View commit details
    Browse the repository at this point in the history
  51. fs: call the callback with an error if writeSync fails

    Catch SyncWriteStream write file error.
    
    Fixes: #47948
    Signed-off-by: killagu <killa123@126.com>
    PR-URL: #47949
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    killagu authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5354af3 View commit details
    Browse the repository at this point in the history
  52. deps: update minimatch to 9.0.2

    PR-URL: #48542
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8914a52 View commit details
    Browse the repository at this point in the history
  53. tools: update lint-md-dependencies

    Update to @rollup/plugin-commonjs@25.0.2 and rollup@3.25.2.
    
    PR-URL: #48544
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7d52950 View commit details
    Browse the repository at this point in the history
  54. doc: run license-builder

    PR-URL: #48552
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    github-actions[bot] authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    fbe89e6 View commit details
    Browse the repository at this point in the history
  55. benchmark: add bar.R

    Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
    PR-URL: #47729
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    RafaelGSS authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d1f4331 View commit details
    Browse the repository at this point in the history
  56. src: fix Coverity issue regarding unnecessary copy

    PR-URL: #48565
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    anonrig authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0c38184 View commit details
    Browse the repository at this point in the history
  57. deps: update googletest to ec4fed9

    PR-URL: #48538
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    56249b0 View commit details
    Browse the repository at this point in the history
  58. lib: add option to force handling stopped events

    PR-URL: #48301
    Backport-PR-URL: #49587
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    db355d1 View commit details
    Browse the repository at this point in the history
  59. deps: update zlib to 1.2.13.1-motley-f81f385

    PR-URL: #48541
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6b6d5d9 View commit details
    Browse the repository at this point in the history
  60. doc: update return type for describe

    PR-URL: #48572
    Fixes: #48571
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    shrujalshah28 authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f436ac1 View commit details
    Browse the repository at this point in the history
  61. test: remove test-timers-immediate-queue flaky designation

    PR-URL: #48575
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    df9a9af View commit details
    Browse the repository at this point in the history
  62. test: remove test-crypto-keygen flaky designation

    PR-URL: #48575
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    dd1805e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. deps: update acorn to 8.9.0

    PR-URL: #48484
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    nodejs-github-bot authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    65a6c90 View commit details
    Browse the repository at this point in the history
  2. doc: update security release stewards

    PR-URL: #48569
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    RafaelGSS authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    989ea68 View commit details
    Browse the repository at this point in the history
  3. test: add missing assertions to test-runner-cli

    PR-URL: #48593
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    MoLow authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    6ec5798 View commit details
    Browse the repository at this point in the history
  4. http: null the joinDuplicateHeaders property on cleanup

    Null the `joinDuplicateHeaders` property when the parser is freed.
    
    Refs: #45982
    PR-URL: #48608
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    lpinca authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    01746c7 View commit details
    Browse the repository at this point in the history
  5. doc: fix options order

    Move the `joinDuplicateHeaders` option to the correct alphabetical
    order.
    
    PR-URL: #48617
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    lpinca authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    a9a1394 View commit details
    Browse the repository at this point in the history
  6. test_runner: fixed test shorthands return type

    `test.todo`, `test.only` and `test.skip` are expected to return the
    same as `test`. This commit corrects the inconsistent behavior of
    these shorthands.
    
    Fixes: #48557
    PR-URL: #48555
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    shockerqt authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    f5494fa View commit details
    Browse the repository at this point in the history
  7. src: fix uninitialized field access in AsyncHooks

    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    PR-URL: #48566
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    2 people authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    0c19621 View commit details
    Browse the repository at this point in the history
  8. src: deduplicate X509 getter implementations

    Reorder arguments of internal helper functions such that their order is
    consistent across X509 property getters. Add ReturnPropertyThroughBIO()
    and ReturnProperty(). Use these new helpers to deduplicate code across
    various X509 property getters.
    
    PR-URL: #48563
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Alba Mendez <me@alba.sh>
    tniessen authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    f43eaca View commit details
    Browse the repository at this point in the history
  9. meta: bump github/codeql-action from 2.3.6 to 2.20.1

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.3.6 to 2.20.1.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@83f0fe6...f6e388e)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #48627
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    dependabot[bot] authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    dfed9a7 View commit details
    Browse the repository at this point in the history
  10. meta: bump ossf/scorecard-action from 2.1.3 to 2.2.0

    Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.3 to 2.2.0.
    - [Release notes](https://github.com/ossf/scorecard-action/releases)
    - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
    - [Commits](ossf/scorecard-action@80e868c...08b4669)
    
    ---
    updated-dependencies:
    - dependency-name: ossf/scorecard-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #48628
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    dependabot[bot] authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    34b8e98 View commit details
    Browse the repository at this point in the history
  11. meta: bump step-security/harden-runner from 2.4.0 to 2.4.1

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.4.0 to 2.4.1.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@128a634...55d479f)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #48626
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    dependabot[bot] authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    7ec3709 View commit details
    Browse the repository at this point in the history
  12. tools: update lint-md-dependencies to rollup@3.26.0

    PR-URL: #48631
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    4e53f51 View commit details
    Browse the repository at this point in the history
  13. tools: update eslint to 8.44.0

    PR-URL: #48632
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    nodejs-github-bot authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    31c0715 View commit details
    Browse the repository at this point in the history
  14. meta: bump actions/checkout from 3.5.2 to 3.5.3

    Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@8e5e7e5...c85c95e)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #48625
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    dependabot[bot] authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    51863b8 View commit details
    Browse the repository at this point in the history
  15. child_process: support Symbol.dispose

    PR-URL: #48551
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    611db8d View commit details
    Browse the repository at this point in the history
  16. Revert "test: remove test-crypto-keygen flaky designation"

    This reverts commit 893c000.
    
    Refs: #48575 (comment)
    PR-URL: #48652
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    lpinca authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    a79112b View commit details
    Browse the repository at this point in the history
  17. events: allow safely adding listener to abortSignal

    PR-URL: #48596
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    a68a67f View commit details
    Browse the repository at this point in the history
  18. http2: send RST code 8 on AbortController signal

    Fixes: #47321
    Refs: https://www.rfc-editor.org/rfc/rfc7540#section-7
    PR-URL: #48573
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    devm33 authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    7c7230a View commit details
    Browse the repository at this point in the history
  19. doc: mention git node release prepare

    Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
    PR-URL: #48644
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    RafaelGSS authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    d723e87 View commit details
    Browse the repository at this point in the history
  20. doc: clarify transform._transform() callback argument logic

    Clarify that `transform._transform()` callback second argument is
    used only if the first argument is `null`, i.e. no error occured
    processing the chunk.
    
    PR-URL: #48680
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    rafasofizada authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    1aa798d View commit details
    Browse the repository at this point in the history
  21. events: fix bug listenerCount don't compare wrapped listener

    When add listener by once, it will be wrapped into another function.
    And when pass listener and there is just one event listener added by
    once, it will return 0 even if passed listener equal wrapped event
    listener.
    
    Refs: #46523
    PR-URL: #48592
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    yuzheng14 authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    3b8ec34 View commit details
    Browse the repository at this point in the history
  22. src: remove kEagerCompile for CompileFunction

    It wasn't doing anything, and actually enabling it would cause some
    tests to fail.
    
    Refs: #48576
    PR-URL: #48671
    Refs: v8/v8@cb00db4
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    kvakil authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    3f65598 View commit details
    Browse the repository at this point in the history
  23. deps: V8: cherry-pick cb00db4dba6c

    Original commit message:
    
        [compiler] fix CompileFunction ignoring kEagerCompile
    
        v8::ScriptCompiler::CompileFunction was ignoring kEagerCompile. Unlike
        the other functions in v8::ScriptCompiler, it was not actually
        propagating kEagerCompile to the parser. The newly updated test fails
        without this change.
    
        I did some archeology and found that this was commented out since the
        original CL in https://crrev.com/c/980944.
    
        As far as I know Node.js is the main consumer of this particular API.
        This CL speeds up Node.js's overall startup time by ~13%.
    
        Change-Id: Ifc3cd6653555194d46ca48db14f7ba7a4afe0053
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4571822
        Commit-Queue: Marja Hölttä <marja@chromium.org>
        Reviewed-by: Marja Hölttä <marja@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#87944}
    
    Refs: v8/v8@cb00db4
    PR-URL: #48671
    Refs: #48576
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    kvakil authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    bcb255d View commit details
    Browse the repository at this point in the history
  24. tools: update lint-md-dependencies to rollup@3.26.2

    PR-URL: #48705
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    7399481 View commit details
    Browse the repository at this point in the history
  25. tools: update doc to unist-util-select@5.0.0 unist-util-visit@5.0.0

    PR-URL: #48714
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    e2688c8 View commit details
    Browse the repository at this point in the history
  26. esm: fix emit deprecation on legacy main resolve

    PR-URL: #48664
    Refs: #48325
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    aduh95 authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    d9a800e View commit details
    Browse the repository at this point in the history
  27. http2: use addAbortListener

    PR-URL: #48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    be88f7c View commit details
    Browse the repository at this point in the history
  28. readline: use addAbortListener

    PR-URL: #48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    cb51ef2 View commit details
    Browse the repository at this point in the history
  29. stream: use addAbortListener

    PR-URL: #48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    3dd82b1 View commit details
    Browse the repository at this point in the history
  30. dgram: use addAbortListener

    PR-URL: #48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    f3c4300 View commit details
    Browse the repository at this point in the history
  31. child_process: use addAbortListener

    PR-URL: #48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    b5df084 View commit details
    Browse the repository at this point in the history
  32. lib: use addAbortListener

    PR-URL: #48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    f74c2fc View commit details
    Browse the repository at this point in the history
  33. dgram: socket add asyncDispose

    PR-URL: #48717
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    573eb4b View commit details
    Browse the repository at this point in the history
  34. net: server add asyncDispose

    PR-URL: #48717
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    f892163 View commit details
    Browse the repository at this point in the history
  35. test: move test-net-throttle to parallel

    The test is not very resource intensive. It just writes data to a TCP
    socket until backpressure is reached. Move it parallel.
    
    PR-URL: #48599
    Fixes: #40507
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    lpinca authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    33886b2 View commit details
    Browse the repository at this point in the history
  36. test: deflake test-net-throttle

    Sometimes the test completes with only two data chunks received on the
    client.
    
    Fixes: #40507
    PR-URL: #48599
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    lpinca authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    01eaccc View commit details
    Browse the repository at this point in the history
  37. deps: update acorn to 8.10.0

    PR-URL: #48713
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    59fca4e View commit details
    Browse the repository at this point in the history
  38. fs, stream: initial Symbol.dispose and Symbol.asyncDispose support

    Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
    PR-URL: #48518
    Backport-PR-URL: #49598
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    2 people authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    3a8586b View commit details
    Browse the repository at this point in the history
  39. deps: upgrade to libuv 1.45.0

    - linux: introduce io_uring support libuv/libuv#3952
    - src: add new metrics APIs libuv/libuv#3749
    - unix,win: give thread pool threads an 8 MB stack libuv/libuv#3787
    - win,unix: change execution order of timers libuv/libuv#3927
    
    Fixes: #43931
    Fixes: #42496
    Fixes: #47715
    Fixes: #47259
    Fixes: #47241
    PR-URL: #48078
    Backport-PR-URL: #49591
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    santigimeno authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    fb2b80f View commit details
    Browse the repository at this point in the history
  40. deps: upgrade to libuv 1.46.0

    Notable changes
    - fs: use WTF-8 on Windows: libuv/libuv#2970
    - linux: add some more iouring backed fs ops: libuv/libuv#4012
    
    Important bugs fixed
    - linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
    - src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
    
    PR-URL: #48618
    Backport-PR-URL: #49591
    Fixes: #48512
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    PR-URL: #48078
    santigimeno authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    88855e0 View commit details
    Browse the repository at this point in the history
  41. build: sync libuv header change

    PR-URL: #48429
    Backport-PR-URL: #49591
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    PR-URL: #48078
    gengjiawen authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    7dc731d View commit details
    Browse the repository at this point in the history
  42. deps: add missing thread-common.c in uv.gyp

    PR-URL: #49410
    Backport-PR-URL: #49591
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    PR-URL: #48078
    santigimeno authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    ea23870 View commit details
    Browse the repository at this point in the history
  43. timers: support Symbol.dispose

    PR-URL: #48633
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    MoLow authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    7822a54 View commit details
    Browse the repository at this point in the history
  44. test: mark test-http-regr-gh-2928 as flaky

    It has been flaky for more than a year. Mark it as flaky to avoid
    blocking the CI.
    
    PR-URL: #49565
    Refs: nodejs/reliability#658
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    joyeecheung authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    279c4f6 View commit details
    Browse the repository at this point in the history
  45. doc: add release key for Ulises Gascon

    PR-URL: #49196
    Refs: nodejs/Release#892
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    UlisesGascon authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    e78824e View commit details
    Browse the repository at this point in the history
  46. doc: fix ambiguity in http.md and https.md

    PR-URL: #48692
    Fixes: #48688
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    an5er authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    42ecd46 View commit details
    Browse the repository at this point in the history
  47. tools: run fetch_deps.py with Python 3

    Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
    which spawns `glient`, with Python 3.
    
    PR-URL: #48729
    Fixes: #48728
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    richardlau authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    4826379 View commit details
    Browse the repository at this point in the history
  48. build: do not pass target toolchain flags to host toolchain

    Fixes target toolchain arguments being passed to the host toolchain when
    cross-compiling. For example, -m64 is not available on aarch64.
    
    PR-URL: #48597
    Reviewed-By: Richard Lau <rlau@redhat.com>
    tie authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    9cb18b3 View commit details
    Browse the repository at this point in the history
  49. src: make BaseObject iteration order deterministic

    Previously we just rely on the unordered_set order to iterate over
    the BaseObjects, which is not deterministic.
    
    The iteration is only used in printing, verification, and snapshot
    generation. In the first two cases the performance overhead of
    sorting does not matter because they are only used for debugging.
    In the last case the determinism is more important than the trivial
    overhead of sorting. So this patch makes the iteration deterministic
    by sorting the set first, as what is already being done when we
    drain the queue.
    
    PR-URL: #48702
    Refs: nodejs/build#3043
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    joyeecheung authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    572b82f View commit details
    Browse the repository at this point in the history
  50. deps: update minimatch to 9.0.3

    PR-URL: #48704
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    7e04242 View commit details
    Browse the repository at this point in the history
  51. doc: add atlowChemi to collaborators

    PR-URL: #48757
    Fixes: #48603
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    249879e View commit details
    Browse the repository at this point in the history
  52. permission: add debug log when inserting fs nodes

    Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
    PR-URL: #48677
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    RafaelGSS authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    7aaecce View commit details
    Browse the repository at this point in the history
  53. test: fix flaky test-string-decode.js on x86

    Removes flakiness from the mentioned test due to the x86 memory limit
    
    PR-URL: #48750
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    StefanStojanovic authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    2c75b9e View commit details
    Browse the repository at this point in the history
  54. child_process: harden against prototype pollution

    PR-URL: #48726
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    LiviaMedeiros authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    cc33a18 View commit details
    Browse the repository at this point in the history
  55. deps: update nghttp2 to 1.55.0

    PR-URL: #48746
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    c8da8c8 View commit details
    Browse the repository at this point in the history
  56. permission: fix data types in PrintTree

    * The first argument `node` should be a const pointer.
    * The second argument `spaces` should not be a signed integer type.
    * The local variable `child` should be size_t.
    * The local variable `pair` in the range declaration should be a
      reference type to avoid copying the object.
    
    Refs: #48677
    PR-URL: #48770
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    tniessen authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    804d880 View commit details
    Browse the repository at this point in the history
  57. doc: expand on squashing and rebasing to land a PR

    PR-URL: #48751
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    legendecas authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    d3041df View commit details
    Browse the repository at this point in the history
  58. util: use primordials.ArrayPrototypeIndexOf instead of mutable method

    PR-URL: #48586
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    DaisyDogs07 authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    0a022c4 View commit details
    Browse the repository at this point in the history
  59. crypto: update root certificates to NSS 3.93

    This is the certdata.txt[0] from NSS 3.93, released on 2023-06-29.
    
    This is the version of NSS that shipped in Firefox 116 on
    2023-08-01.
    
    Certificates added:
    - Sectigo Public Server Authentication Root E46
    - Sectigo Public Server Authentication Root R46
    - SSL.com TLS RSA Root CA 2022
    - SSL.com TLS ECC Root CA 2022
    - Atos TrustedRoot Root CA ECC TLS 2021
    - Atos TrustedRoot Root CA RSA TLS 2021
    
    Certificates removed:
    - Hongkong Post Root CA 1
    - E-Tugra Certification Authority
    - E-Tugra Global Root CA RSA v3
    - E-Tugra Global Root CA ECC v3
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_93_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: #49341
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and ruyadorno committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    490fc00 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. 2023-09-18, Version 18.18.0 'Hydrogen' (LTS)

    Notable changes:
    
    build:
      * sync libuv header change (Jiawen Geng) #48078
    crypto:
      * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
      * update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
    deps:
      * add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
      * upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
      * upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
    doc:
      * add atlowChemi to collaborators (atlowChemi) #48757
      * add vmoroz to collaborators (Vladimir Morozov) #48527
      * add kvakil to collaborators (Keyhan Vakil) #48449
    esm:
      * (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
    events:
      * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
    fs, stream:
      * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
    net:
      * add autoSelectFamily global getter and setter (Paolo Insogna) #45777
    url:
      * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
    
    PR-URL: #49220
    ruyadorno committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    ab5fa2a View commit details
    Browse the repository at this point in the history