fs: add the options param description in openAsBlob() #49308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
deokjinkim
approved these changes
Aug 24, 2023
deokjinkim
added
author ready
github-actions
bot
removed
the
request-ci
LiviaMedeiros
approved these changes
Aug 25, 2023
LiviaMedeiros
added
the
commit-queue
benjamingr
approved these changes
Aug 25, 2023
lpinca
approved these changes
Aug 25, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 76e659a |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #49308 Refs: https://github.com/nodejs/node/blob/main/doc/api/fs.md#fsopenasblobpath-options Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49308 Refs: https://github.com/nodejs/node/blob/main/doc/api/fs.md#fsopenasblobpath-options Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/node/blob/main/doc/api/fs.md#fsopenasblobpath-options