Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix embedtest not running code #49502

Closed
wants to merge 3 commits into from
Closed

test: fix embedtest not running code #49502

wants to merge 3 commits into from

Conversation

mmomtchev
Copy link
Contributor

@mmomtchev mmomtchev commented Sep 5, 2023 •
edited

Fix embedtest and add a test that tests the testing harness

Fixes #49501

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Sep 5, 2023
@mmomtchev
Copy link
Contributor Author

@joyeecheung Maybe you should take over this PR because this is more than I bargained for

@joyeecheung
Copy link
Member

Thanks for reporting it, I opened #49506

@mmomtchev mmomtchev closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

embedtest doesn't actually run any code
3 participants
@mmomtchev @joyeecheung @nodejs-github-bot