Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix print results in events #49548

Merged
merged 1 commit into from Sep 19, 2023
Merged

doc: fix print results in events #49548

merged 1 commit into from Sep 19, 2023

Conversation

pluris
Copy link
Contributor

@pluris pluris commented Sep 8, 2023

In the mjs example, when printing this, it is displayed as undefined.

Refs: #49537

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Sep 8, 2023
@OshriAsulin
Copy link
Contributor

@MoLow

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit f72784b into nodejs:main Sep 19, 2023
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f72784b

@atlowChemi atlowChemi linked an issue Sep 19, 2023 that may be closed by this pull request
Output result different from document in mjs example of Events #49537
Closed
@atlowChemi atlowChemi mentioned this pull request Sep 19, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@pluris @ruyadorno
doc: fix print results in events
3529448 
PR-URL: #49548
Refs: #49537
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@pluris @alexfernandez
doc: fix print results in events
ce0709f 
PR-URL: nodejs#49548
Refs: nodejs#49537
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@pluris pluris deleted the fix/doc_events branch November 8, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output result different from document in mjs example of Events
6 participants
@pluris @OshriAsulin @nodejs-github-bot @lpinca @MoLow @aymen94