fs: adjust typecheck for `type` in `fs.symlink()` #49741

LiviaMedeiros · 2023-09-20T19:41:44Z

Alternative to: #44641

Throws TypeError instead of Error
Enables autodetection on Windows if type === undefined (as intended in win, fs: detect if symlink target is a directory #23724)
Explicitly disallows unknown strings and non-string values

lib/internal/errors.js

nodejs-github-bot · 2023-09-21T14:32:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54124/

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3258/

aduh95 · 2023-09-24T14:04:38Z

Ping @nodejs/TSC for reviews since this is semver-major.
Aside: The CITGM is quite hard to decipher, hopefully nodejs/citgm#959 will fix that.

aduh95 · 2023-09-29T10:44:31Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3282/

nodejs-github-bot · 2023-09-29T12:50:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54369/

lib/fs.js

Mifrill · 2023-10-17T15:59:06Z

lib/internal/fs/utils.js

+  switch (type) {
+    case undefined:
+    case null:
+    case 'file':
+      return 0;
+    case 'dir':
+      return UV_FS_SYMLINK_DIR;
+    case 'junction':
+      return UV_FS_SYMLINK_JUNCTION;


Suggested change

switch (type) {

case undefined:

case null:

case 'file':

return 0;

case 'dir':

return UV_FS_SYMLINK_DIR;

case 'junction':

return UV_FS_SYMLINK_JUNCTION;

const linkTypes = {

undefined: 0,

null: 0,

file: 0,

dir: UV_FS_SYMLINK_DIR,

junction: UV_FS_SYMLINK_JUNCTION

};

return linkTypes[type] || 0;

The || 0 is a fallback in case the type is not found in the linkTypes object. If type is not one of the defined values in the linkTypes object, linkType will default to 0. This ensures that linkType always has a value and doesn't become undefined. It's a way to handle unexpected or unknown values for type.

We intentionally don't fallback to file. If an unknown type is passed, we must throw TypeError, which is done by validateOneOf().

mcollina

lgtm

nodejs-github-bot · 2023-11-18T07:55:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55735/

nodejs-github-bot · 2024-04-14T08:55:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58364/

larson-carter

Piggybacking on what others have said. I've noticed that this is a little older PR, however I've been spending time going thru them.

I notice in this one that it is a essential feature and I think that it needs to be merged as well.

LGTM?

nodejs-github-bot · 2024-05-05T08:30:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58944/

nodejs-github-bot · 2024-05-05T11:16:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58952/

nodejs-github-bot · 2024-05-05T14:52:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58957/

nodejs-github-bot · 2024-05-05T19:49:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58963/

aduh95 · 2024-05-05T22:23:28Z

FreeBSD CI is failing consistently

../deps/v8/src/base/small-vector.h:25:3: error: static_assert failed due to requirement '::v8::base::is_trivially_copyable<std::pair<const v8::internal::compiler::turboshaft::PhiOp *, const v8::internal::compiler::turboshaft::OpIndex>>::value' "T should be trivially copyable"
  ASSERT_TRIVIALLY_COPYABLE(T);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/src/base/macros.h:206:3: note: expanded from macro 'ASSERT_TRIVIALLY_COPYABLE'
  static_assert(::v8::base::is_trivially_copyable<T>::value, \
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/src/compiler/turboshaft/loop-unrolling-reducer.h:431:65: note: in instantiation of template class 'v8::base::SmallVector<std::pair<const v8::internal::compiler::turboshaft::PhiOp *, const v8::internal::compiler::turboshaft::OpIndex>, 16>' requested here
  base::SmallVector<std::pair<const PhiOp*, const OpIndex>, 16> phis;
                                                                ^
1 error generated.

targos · 2024-05-06T04:33:27Z

FreeBSD should be skipped. This needs a rebase to not be identified as Node.js 21.

Throws `TypeError` instead of `Error` Enables autodetection on Windows if `type === undefined` Explicitly disallows unknown strings and non-string values

github-actions · 2024-05-06T06:27:13Z

Failed to start CI

   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/8964951019

nodejs-github-bot · 2024-05-06T06:28:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58976/

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3429/

nodejs-github-bot · 2024-05-06T08:56:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58981/

nodejs-github-bot · 2024-05-06T13:18:43Z

Landed in f202322

Throws `TypeError` instead of `Error` Enables autodetection on Windows if `type === undefined` Explicitly disallows unknown strings and non-string values PR-URL: nodejs#49741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 20, 2023

LiviaMedeiros added semver-major PRs that contain breaking changes and should be released in the next major version. needs-citgm PRs that need a CITGM CI run. labels Sep 20, 2023

aduh95 reviewed Sep 20, 2023

View reviewed changes

lib/internal/errors.js Show resolved Hide resolved

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023

This comment was marked as outdated.

Sign in to view

aduh95 approved these changes Sep 21, 2023

View reviewed changes

github-actions bot mentioned this pull request Sep 22, 2023

CI Reliability 2023-09-22 nodejs/reliability#673

Open

17 tasks

lpinca approved these changes Sep 22, 2023

View reviewed changes

This was referenced Sep 23, 2023

CI Reliability 2023-09-23 nodejs/reliability#674

Open

CI Reliability 2023-09-24 nodejs/reliability#675

Open

anonrig reviewed Sep 29, 2023

View reviewed changes

lib/fs.js Show resolved Hide resolved

RafaelGSS approved these changes Oct 9, 2023

View reviewed changes

Mifrill reviewed Oct 17, 2023

View reviewed changes

mcollina approved these changes Nov 18, 2023

View reviewed changes

LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 18, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2023

jasnell approved these changes Nov 19, 2023

View reviewed changes

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2024

This comment was marked as outdated.

Sign in to view

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2024

larson-carter approved these changes Apr 17, 2024

View reviewed changes

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024

aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2024

LiviaMedeiros force-pushed the fs-forbit-symlink-nonstring branch from f05c863 to 53e1933 Compare May 6, 2024 06:15

LiviaMedeiros added 2 commits May 6, 2024 14:16

fs: adjust typecheck for type in fs.symlink()

840e418

Throws `TypeError` instead of `Error` Enables autodetection on Windows if `type === undefined` Explicitly disallows unknown strings and non-string values

squash: move ERR_FS_INVALID_SYMLINK_TYPE to removed section

5396244

LiviaMedeiros force-pushed the fs-forbit-symlink-nonstring branch from 53e1933 to 5396244 Compare May 6, 2024 06:17

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 6, 2024

LiviaMedeiros removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 6, 2024

gireeshpunathil approved these changes May 6, 2024

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 6, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024

nodejs-github-bot merged commit f202322 into nodejs:main May 6, 2024
59 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: adjust typecheck for `type` in `fs.symlink()` #49741

fs: adjust typecheck for `type` in `fs.symlink()` #49741

LiviaMedeiros commented Sep 20, 2023

This comment was marked as outdated.

nodejs-github-bot commented Sep 21, 2023 •

edited by LiviaMedeiros

aduh95 commented Sep 24, 2023

aduh95 commented Sep 29, 2023

nodejs-github-bot commented Sep 29, 2023

Mifrill Oct 17, 2023 •

edited

LiviaMedeiros Nov 18, 2023

mcollina left a comment

nodejs-github-bot commented Nov 18, 2023

This comment was marked as outdated.

nodejs-github-bot commented Apr 14, 2024

larson-carter left a comment

nodejs-github-bot commented May 5, 2024

nodejs-github-bot commented May 5, 2024

nodejs-github-bot commented May 5, 2024

nodejs-github-bot commented May 5, 2024

aduh95 commented May 5, 2024

targos commented May 6, 2024

github-actions bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024 •

edited by LiviaMedeiros

nodejs-github-bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024

fs: adjust typecheck for type in fs.symlink() #49741

fs: adjust typecheck for type in fs.symlink() #49741

Conversation

LiviaMedeiros commented Sep 20, 2023

This comment was marked as outdated.

nodejs-github-bot commented Sep 21, 2023 • edited by LiviaMedeiros

aduh95 commented Sep 24, 2023

aduh95 commented Sep 29, 2023

nodejs-github-bot commented Sep 29, 2023

Mifrill Oct 17, 2023 • edited

Choose a reason for hiding this comment

LiviaMedeiros Nov 18, 2023

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 18, 2023

This comment was marked as outdated.

nodejs-github-bot commented Apr 14, 2024

larson-carter left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented May 5, 2024

nodejs-github-bot commented May 5, 2024

nodejs-github-bot commented May 5, 2024

nodejs-github-bot commented May 5, 2024

aduh95 commented May 5, 2024

targos commented May 6, 2024

github-actions bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024 • edited by LiviaMedeiros

nodejs-github-bot commented May 6, 2024

nodejs-github-bot commented May 6, 2024

fs: adjust typecheck for `type` in `fs.symlink()` #49741

fs: adjust typecheck for `type` in `fs.symlink()` #49741

nodejs-github-bot commented Sep 21, 2023 •

edited by LiviaMedeiros

Mifrill Oct 17, 2023 •

edited

nodejs-github-bot commented May 6, 2024 •

edited by LiviaMedeiros