test: update skip for moved test-wasm-web-api
#49958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: nodejs#49869 Refs: nodejs#47299 Refs: nodejs#47297
nodejs-github-bot
added
esm
github-actions
bot
removed
the
request-ci
joyeecheung
approved these changes
Sep 29, 2023
richardlau
added
the
author ready
lpinca
approved these changes
Sep 29, 2023
richardlau
added
the
commit-queue
GeoffreyBooth
approved these changes
Sep 29, 2023
GeoffreyBooth
added
the
fast-track
|
Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49958 ✔ Done loading data for nodejs/node/pull/49958 ----------------------------------- PR info ------------------------------------ Title test: update skip for moved `test-wasm-web-api` (#49958) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richardlau:fixskip -> nodejs:main Labels test, esm, fast-track, author ready, needs-ci Commits 1 - test: update skip for moved `test-wasm-web-api` Committers 1 - Richard Lau PR-URL: https://github.com/nodejs/node/pull/49958 Refs: https://github.com/nodejs/node/pull/49869 Refs: https://github.com/nodejs/node/pull/47299 Refs: https://github.com/nodejs/node/issues/47297 Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: Geoffrey Booth ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49958 Refs: https://github.com/nodejs/node/pull/49869 Refs: https://github.com/nodejs/node/pull/47299 Refs: https://github.com/nodejs/node/issues/47297 Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: Geoffrey Booth -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 29 Sep 2023 15:56:37 GMT ✔ Approvals: 3 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/49958#pullrequestreview-1651113176 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49958#pullrequestreview-1651340315 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49958#pullrequestreview-1651415560 ℹ This PR is being fast-tracked ✘ This PR needs to wait 43 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-09-29T17:32:55Z: https://ci.nodejs.org/job/node-test-pull-request/54383/ - Querying data for job/node-test-pull-request/54383/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6356595801 |
richardlau
removed
the
commit-queue-failed
31 tasks
richardlau
added
the
flaky-test
MoLow
approved these changes
Sep 30, 2023
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6c9625d |
16 tasks
GeoffreyBooth
pushed a commit
to GeoffreyBooth/node
that referenced
this pull request
Oct 1, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: nodejs#49869 Refs: nodejs#47299 Refs: nodejs#47297 PR-URL: nodejs#49958 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
12 tasks
18 tasks
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: nodejs#49869 Refs: nodejs#47299 Refs: nodejs#47297 PR-URL: nodejs#49958 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: #49869 Refs: #47299 Refs: #47297 PR-URL: #49958 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: nodejs#49869 Refs: nodejs#47299 Refs: nodejs#47297 PR-URL: nodejs#49958 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-wasm-web-apiwas moved fromtest/paralleltotest/es-modules. Update the status files for parallel and es-modules accordingly.Refs: #49869
Refs: #47299
Refs: #47297
Started seeing
test-wasm-web-apifailing for arm64 debug builds again today.e.g. https://ci.nodejs.org/job/node-test-commit-arm-debug/nodes=ubuntu2004_debug-arm64/9557/ seems to be the earliest build that it happened in.
According to the reliability repo, we saw this test flaking at the beginning of the year. We started skipping it on arm in #47299. #49869 moved the test from
test/paralleltotest/es-modulesbut didn't move the corresponding entry intest/parallel/parallel.status.cc @nodejs/loaders