Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update doc to highlight.js@11.9.0 remark-frontmatter@5.0.0 remark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.0.0 unified@11.0.3 #49988

Merged
merged 3 commits into from Oct 26, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Oct 1, 2023

This is an automated update of doc to highlight.js@11.9.0 remark-frontmatter@5.0.0 remark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.0.0 unified@11.0.3.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 1, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 1, 2023
@lpinca
Copy link
Member

lpinca commented Oct 3, 2023

I'm not sure why the coverage job fails. Can we ignore it?

@nodejs-github-bot nodejs-github-bot changed the title tools: update doc to remark-frontmatter@5.0.0 remark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.0.0 unified@11.0.3 tools: update doc to highlight.js@11.9.0 remark-frontmatter@5.0.0 remark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.0.0 unified@11.0.3 Oct 15, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 23, 2023
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- hightlight.js@11.9.0
- remark-frontmatter@5.0.0
- remark-gfm@4.0.0
- remark-html@16.0.1
- remark-parse@11.0.0
- remark-rehype@11.0.0
- unified@11.0.3
…ark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.0.0 unified@11.0.3
…ark-gfm@4.0.0 remark-html@16.0.1 remark-parse@11.0.0 remark-rehype@11.0.0 unified@11.0.3
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6431c65 into main Oct 26, 2023
20 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-doc branch October 26, 2023 12:42
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 6431c65

@richardlau
Copy link
Member

richardlau commented Oct 26, 2023

I think this has broken the without-intl build:
https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/40113/console

17:31:46 npm WARN cli npm v10.2.0 does not support Node.js v22.0.0-pre. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.
17:31:47 
17:31:47 added 109 packages, and audited 110 packages in 1s
17:31:47 
17:31:47 94 packages are looking for funding
17:31:47   run `npm fund` for details
17:31:47 
17:31:47 found 0 vulnerabilities
17:31:47 file:///home/iojs/build/workspace/node-test-commit-linux-containered/tools/doc/node_modules/micromark-util-character/index.js:5
17:31:47 const unicodePunctuationInternal = regexCheck(/\p{P}/u)
17:31:47                                               ^^^^^^^^
17:31:47 
17:31:47 SyntaxError: Invalid regular expression: /\p{P}/u: Invalid property name
17:31:47     at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:155:18)
17:31:47     at callTranslator (node:internal/modules/esm/loader:285:14)
17:31:47     at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:291:30)
17:31:47 
17:31:47 Node.js v22.0.0-pre
17:31:47 /bin/sh: 5: node: not found
17:31:47 Makefile:374: recipe for target 'test/addons/.docbuildstamp' failed

Opened a revert: #50414

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
- hightlight.js@11.9.0
- remark-frontmatter@5.0.0
- remark-gfm@4.0.0
- remark-html@16.0.1
- remark-parse@11.0.0
- remark-rehype@11.0.0
- unified@11.0.3

PR-URL: nodejs#49988
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
- hightlight.js@11.9.0
- remark-frontmatter@5.0.0
- remark-gfm@4.0.0
- remark-html@16.0.1
- remark-parse@11.0.0
- remark-rehype@11.0.0
- unified@11.0.3

PR-URL: #49988
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
- hightlight.js@11.9.0
- remark-frontmatter@5.0.0
- remark-gfm@4.0.0
- remark-html@16.0.1
- remark-parse@11.0.0
- remark-rehype@11.0.0
- unified@11.0.3

PR-URL: #49988
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants