Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set inspector async hook test as flaky #50252

Merged
merged 1 commit into from
Oct 18, 2023
Merged

test: set inspector async hook test as flaky #50252

merged 1 commit into from
Oct 18, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 18, 2023

Ref: #50222

@anonrig anonrig added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 18, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54959/

@H4ad H4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 18, 2023
@lpinca
Copy link
Member

lpinca commented Oct 18, 2023 •
edited

The referenced issue was opened 19 hours ago. I think we should at least ping @nodejs/platform-s390 before marking the test flaky.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit e0bbe56 into nodejs:main Oct 18, 2023
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e0bbe56

targos pushed a commit that referenced this pull request Oct 23, 2023
@anonrig @targos
test: set inspector async hook test as flaky
c874490 
Ref: #50222
PR-URL: #50252
Refs: #50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
test: set inspector async hook test as flaky
d99a5fa 
Ref: nodejs#50222
PR-URL: nodejs#50252
Refs: nodejs#50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
test: set inspector async hook test as flaky
8b260c5 
Ref: #50222
PR-URL: #50252
Refs: #50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @targos
test: set inspector async hook test as flaky
866a399 
Ref: #50222
PR-URL: #50252
Refs: #50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set inspector async hook test as flaky
135bb52 
Ref: nodejs/node#50222
PR-URL: nodejs/node#50252
Refs: nodejs/node#50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set inspector async hook test as flaky
f769e5c 
Ref: nodejs/node#50222
PR-URL: nodejs/node#50252
Refs: nodejs/node#50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@H4ad H4ad H4ad approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anonrig @nodejs-github-bot @lpinca @panva @H4ad