Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set test-watch-mode-inspect as flaky #50259

Merged
merged 1 commit into from
Oct 22, 2023
Merged

test: set test-watch-mode-inspect as flaky #50259

merged 1 commit into from
Oct 22, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 18, 2023

Ref: #49933

cc @nodejs/test_runner

@anonrig anonrig added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 18, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54982/

@cjihrig
Copy link
Contributor

cjihrig commented Oct 18, 2023

cc @ nodejs/test_runner

Is this actually related to the test runner?

MoLow
MoLow approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once I have more time I will take a deeper look into deflaking this

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55008/

@anonrig
Copy link
Member Author

anonrig commented Oct 19, 2023

@MoLow Can you approve fast-track too?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55025/

@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55054/

mhdawson
mhdawson approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55060/

@github-actions github-actions bot mentioned this pull request Oct 21, 2023
Open
24 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55088/

@github-actions github-actions bot mentioned this pull request Oct 22, 2023
Open
29 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit d370ed0 into nodejs:main Oct 22, 2023
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d370ed0

@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Open
26 tasks
targos pushed a commit that referenced this pull request Oct 23, 2023
@anonrig @targos
test: set test-watch-mode-inspect as flaky
63b7059 
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
test: set test-watch-mode-inspect as flaky
45e3e91 
PR-URL: nodejs#50259
Refs: nodejs#49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
test: set test-watch-mode-inspect as flaky
baa04b7 
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @targos
test: set test-watch-mode-inspect as flaky
a0bb30c 
PR-URL: #50259
Refs: #49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-watch-mode-inspect as flaky
b856418 
PR-URL: nodejs/node#50259
Refs: nodejs/node#49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-watch-mode-inspect as flaky
c9cab9b 
PR-URL: nodejs/node#50259
Refs: nodejs/node#49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@MoLow MoLow MoLow approved these changes

@mhdawson mhdawson mhdawson approved these changes

@H4ad H4ad H4ad approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@anonrig @nodejs-github-bot @cjihrig @GeoffreyBooth @MoLow @mhdawson @H4ad @aduh95